Re: [PATCH]Add -fprofile-use option for check_effective_target_freorder.

2015-10-27 Thread Bernd Schmidt
On 10/27/2015 12:38 PM, Maxim Ostapenko wrote: Anyway, disabling any compile options provided by user explicitly sounds like a bad idea for me, so disabling -freorder-blocks-and-partition if it can't find .gcda file seems to be not acceptable. The current situation is that -fr-b-a-p is disable

Re: [PATCH]Add -fprofile-use option for check_effective_target_freorder.

2015-10-27 Thread Maxim Ostapenko
On 27/10/15 14:06, Bernd Schmidt wrote: On 10/27/2015 11:54 AM, Renlin Li wrote: Yes. In all of the related testcases, only -freorder-and-partition flag is provided explicitly. How about creating a new dg-add-options for freorder? proc add_options_for_freorder { flags } { return "$flags -f

Re: [PATCH]Add -fprofile-use option for check_effective_target_freorder.

2015-10-27 Thread Bernd Schmidt
On 10/27/2015 11:54 AM, Renlin Li wrote: Yes. In all of the related testcases, only -freorder-and-partition flag is provided explicitly. How about creating a new dg-add-options for freorder? proc add_options_for_freorder { flags } { return "$flags -freorder-blocks-and-partition -fprofile-us

Re: [PATCH]Add -fprofile-use option for check_effective_target_freorder.

2015-10-27 Thread Renlin Li
On 26/10/15 13:24, Bernd Schmidt wrote: On 10/26/2015 02:17 PM, Teresa Johnson wrote: On Mon, Oct 26, 2015 at 2:00 AM, Renlin Li wrote: * lib/target-supports.exp (check_effective_target_freorder): Add -fprofile-use flag. Hmmm, the testcases themselves which use this predicate onl

Re: [PATCH]Add -fprofile-use option for check_effective_target_freorder.

2015-10-26 Thread Bernd Schmidt
On 10/26/2015 02:17 PM, Teresa Johnson wrote: On Mon, Oct 26, 2015 at 2:00 AM, Renlin Li wrote: * lib/target-supports.exp (check_effective_target_freorder): Add -fprofile-use flag. Hmmm, the testcases themselves which use this predicate only use -freorder-and-partition, so maybe th

Re: [PATCH]Add -fprofile-use option for check_effective_target_freorder.

2015-10-26 Thread Teresa Johnson
Looks good to me, but I don't have approval rights. Thanks for fixing, Teresa On Mon, Oct 26, 2015 at 2:00 AM, Renlin Li wrote: > Hi all, > > After r228136, flag_reorder_blocks_and_partition is canceled when > -fprofile-use is not specified. > > In this case check_effective_target_freorder() is n

[PATCH]Add -fprofile-use option for check_effective_target_freorder.

2015-10-26 Thread Renlin Li
Hi all, After r228136, flag_reorder_blocks_and_partition is canceled when -fprofile-use is not specified. In this case check_effective_target_freorder() is not able to check the proper target support. This is a simple patch to add "-fprofile-use" option that effective target check. Okay to