Re: [PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

2019-01-10 Thread Matthias Kretz
On Donnerstag, 10. Januar 2019 14:27:40 CET Matthias Kretz wrote: > On Donnerstag, 10. Januar 2019 11:39:56 CET Jakub Jelinek wrote: > > On Thu, Jan 10, 2019 at 10:46:14AM +0100, Dr. Matthias Kretz wrote: > > > _mm_fixupimm_ps(_mm_getexp_ps(x), x, _mm_set1_epi32(0x00550433), 0x00); > > > > I guess

Re: [PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

2019-01-10 Thread Matthias Kretz
On Donnerstag, 10. Januar 2019 11:39:56 CET Jakub Jelinek wrote: > On Thu, Jan 10, 2019 at 10:46:14AM +0100, Dr. Matthias Kretz wrote: > > _mm_fixupimm_ps(_mm_getexp_ps(x), x, _mm_set1_epi32(0x00550433), 0x00); > > I guess you could use > _mm_mask_fixupimm_ps(_mm_getexp_ps(x), -1, x, _mm_set1_epi3

Re: [PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

2019-01-10 Thread Jakub Jelinek
On Thu, Jan 10, 2019 at 10:46:14AM +0100, Dr. Matthias Kretz wrote: > I strongly believe this API change needs to be reverted (unless I completely > misunderstand how vfixupimm works): > > 1. This change breaks API with previous GCC releases. I.e. source code that > compiled with GCC 8 will not

Re: [PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

2019-01-10 Thread Dr. Matthias Kretz
I strongly believe this API change needs to be reverted (unless I completely misunderstand how vfixupimm works): 1. This change breaks API with previous GCC releases. I.e. source code that compiled with GCC 8 will not compile with GCC 9 anymore. If you really want a "simplified" fixup intrinsic

Re: [PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

2018-11-05 Thread H.J. Lu
On Sun, Nov 4, 2018 at 11:00 PM Uros Bizjak wrote: > > On Mon, Nov 5, 2018 at 6:54 AM Wei Xiao wrote: > > > > > Please also rename these: > > > > > > _mm512_mask_fixupimm_round_pd (__m512d __A, __mmask8 __U, __m512d __B, > > > __m512i __C, const int __imm, const int __R) > >

Re: [PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

2018-11-04 Thread Uros Bizjak
On Mon, Nov 5, 2018 at 6:54 AM Wei Xiao wrote: > > > Please also rename these: > > > > _mm512_mask_fixupimm_round_pd (__m512d __A, __mmask8 __U, __m512d __B, > > __m512i __C, const int __imm, const int __R) > > > > _mm512_mask_fixupimm_round_ps (__m512 __A, __mmask16 __U, __m

Re: [PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

2018-11-04 Thread Wei Xiao
> Please also rename these: > > _mm512_mask_fixupimm_round_pd (__m512d __A, __mmask8 __U, __m512d __B, > __m512i __C, const int __imm, const int __R) > > _mm512_mask_fixupimm_round_ps (__m512 __A, __mmask16 __U, __m512 __B, > __m512i __C, const int __imm, c

Re: [PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

2018-11-02 Thread Uros Bizjak
On Fri, Nov 2, 2018 at 11:12 AM Wei Xiao wrote: > > Hi Uros and HJ, > > I have updated the patch according to your remarks as attached. > Ok for trunk? > > Thanks > Wei > > gcc/ > 2018-11-2 Wei Xiao > > *config/i386/avx512fintrin.h: Update VFIXUPIMM* intrinsics. > (_mm512_

Re: [PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

2018-11-02 Thread Wei Xiao
Hi Uros and HJ, I have updated the patch according to your remarks as attached. Ok for trunk? Thanks Wei gcc/ 2018-11-2 Wei Xiao *config/i386/avx512fintrin.h: Update VFIXUPIMM* intrinsics. (_mm512_fixupimm_round_pd): Update parameters and builtin. (_mm512_maskz_

Re: [PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

2018-11-01 Thread Uros Bizjak
On Tue, Oct 30, 2018 at 10:12 AM Wei Xiao wrote: > > Hi, > > The attached patch updates VFIXUPIMM* Intrinsics to align with the > latest Intel® 64 and IA-32 Architectures Software Developer’s Manual > (SDM). > Tested with GCC regression test on x86, no regression. A couple of remarks: -_mm512_fi

[PATCH] x86: Update VFIXUPIMM* Intrinsics to align with the latest Intel SDM

2018-10-30 Thread Wei Xiao
Hi, The attached patch updates VFIXUPIMM* Intrinsics to align with the latest Intel® 64 and IA-32 Architectures Software Developer’s Manual (SDM). Tested with GCC regression test on x86, no regression. Is it ok? Thanks Wei gcc/ 2018-10-30 Wei Xiao *config/i386/avx512fintrin.h: