Re: [PATCH] x86: Revert patches to fix PR target/88794

2019-01-16 Thread Jakub Jelinek
On Wed, Jan 16, 2019 at 10:48:28PM +0800, Wei Xiao wrote: > The original runtime testcases are incorrect and I have fixed them as > attached. > Is it ok to do the revert and fix the testcases for trunk? LGTM. > 2019-01-16 Wei Xiao > > * gcc.target/i386/avx512f-vfixupimmpd-2.c: Fix th

Re: [PATCH] x86: Revert patches to fix PR target/88794

2019-01-16 Thread Wei Xiao
The original runtime testcases are incorrect and I have fixed them as attached. Is it ok to do the revert and fix the testcases for trunk? Wei 2019-01-16 Wei Xiao * gcc.target/i386/avx512f-vfixupimmpd-2.c: Fix the test cases for VFIXUPIMM* intrinsics. * gcc.target/i386

Re: [PATCH] x86: Revert patches to fix PR target/88794

2019-01-16 Thread Wei Xiao
> > Yes, but please test the compiler after the revert. Please also create > > a runtime testcase out of the testcase in the PR. Yes, we have tested it but current runtime testcase can't cover the corner case to expose the incorrectness of SDM. We will add some after the revert. > For r267160, I'd

Re: [PATCH] x86: Revert patches to fix PR target/88794

2019-01-15 Thread Jakub Jelinek
On Tue, Jan 15, 2019 at 04:14:06PM +0100, Uros Bizjak wrote: > On Tue, Jan 15, 2019 at 3:40 PM Wei Xiao wrote: > > > > Hi, > > > > It turns out that the Intel 64 and IA-32 Architectures Software Developer > > Manuals (SDM) description about the fixupimm intrinsic is incorrect. So we > > need > >

Re: [PATCH] x86: Revert patches to fix PR target/88794

2019-01-15 Thread Uros Bizjak
On Tue, Jan 15, 2019 at 3:40 PM Wei Xiao wrote: > > Hi, > > It turns out that the Intel 64 and IA-32 Architectures Software Developer > Manuals (SDM) description about the fixupimm intrinsic is incorrect. So we > need > to revert 3 patches related to it: r265827, r266026 and r267160. > Sorry for

[PATCH] x86: Revert patches to fix PR target/88794

2019-01-15 Thread Wei Xiao
Hi, It turns out that the Intel 64 and IA-32 Architectures Software Developer Manuals (SDM) description about the fixupimm intrinsic is incorrect. So we need to revert 3 patches related to it: r265827, r266026 and r267160. Sorry for the inconvenience. Is it ok? Wei