Re: [PATCH] x86: Replace hard frame pointer with stack pointer - UNITS_PER_WORD

2018-09-03 Thread Florian Weimer
* H. J. Lu: > With > > commit cd557ff63f388ad27c376d0a225e74d3594a6f9d > Author: hjl > Date: Thu Aug 10 15:29:05 2017 + > > i386: Don't use frame pointer without stack access > > When there is no stack access, there is no need to use frame pointer > even if -fno-omit-frame-point

Re: [PATCH] x86: Replace hard frame pointer with stack pointer - UNITS_PER_WORD

2018-09-03 Thread H.J. Lu
On Mon, Sep 3, 2018 at 9:44 AM, Michael Matz wrote: > Hi, > > On Mon, 3 Sep 2018, H.J. Lu wrote: > >> > So, what's the testcase testing then? Before the patch it doesn't ICE, >> > after the patch it doesn't ICE. What should I look out for so I can see >> > that what the testcase is producing wit

Re: [PATCH] x86: Replace hard frame pointer with stack pointer - UNITS_PER_WORD

2018-09-03 Thread Michael Matz
Hi, On Mon, 3 Sep 2018, H.J. Lu wrote: > > So, what's the testcase testing then? Before the patch it doesn't ICE, > > after the patch it doesn't ICE. What should I look out for so I can see > > that what the testcase is producing without the patch is wrong? > > Before the patch, debug info is

Re: [PATCH] x86: Replace hard frame pointer with stack pointer - UNITS_PER_WORD

2018-09-03 Thread H.J. Lu
On Mon, Sep 3, 2018 at 8:20 AM, Michael Matz wrote: > Hi, > > On Mon, 3 Sep 2018, H.J. Lu wrote: > >> > % ./gcc/cc1plus -quiet -O -g -fno-omit-frame-pointer -fno-var-tracking x.cc >> > % ./gcc/cc1plus -quiet -O -g -fno-omit-frame-pointer -fvar-tracking x.cc >> >> It is because of >> >> gc

Re: [PATCH] x86: Replace hard frame pointer with stack pointer - UNITS_PER_WORD

2018-09-03 Thread Michael Matz
Hi, On Mon, 3 Sep 2018, H.J. Lu wrote: > > % ./gcc/cc1plus -quiet -O -g -fno-omit-frame-pointer -fno-var-tracking x.cc > > % ./gcc/cc1plus -quiet -O -g -fno-omit-frame-pointer -fvar-tracking x.cc > > It is because of > > gcc_assert ((SUPPORTS_STACK_ALIGNMENT >&&

Re: [PATCH] x86: Replace hard frame pointer with stack pointer - UNITS_PER_WORD

2018-09-03 Thread H.J. Lu
On Mon, Sep 3, 2018 at 7:32 AM, Michael Matz wrote: > Hi, > > On Sun, 2 Sep 2018, H.J. Lu wrote: > >> Here is the patch to replace hard frame pointer with stack pointer >> - UNITS_PER_WORD in x86 backend. >> >> OK for trunk? >> >> +// { dg-options "-O -g -fno-omit-frame-pointer -fvar-tracking" } >

Re: [PATCH] x86: Replace hard frame pointer with stack pointer - UNITS_PER_WORD

2018-09-03 Thread Michael Matz
Hi, On Sun, 2 Sep 2018, H.J. Lu wrote: > Here is the patch to replace hard frame pointer with stack pointer > - UNITS_PER_WORD in x86 backend. > > OK for trunk? > > +// { dg-options "-O -g -fno-omit-frame-pointer -fvar-tracking" } > + > +struct Foo > +{ > + int bar(int a, int b, int c, int i1,

[PATCH] x86: Replace hard frame pointer with stack pointer - UNITS_PER_WORD

2018-09-02 Thread H.J. Lu
On Sat, Sep 01, 2018 at 06:38:35AM -0500, Segher Boessenkool wrote: > > > > With -fno-omit-frame-pointer, arg pointer is eliminated with hard frame > > pointer. But > > > > commit cd557ff63f388ad27c376d0a225e74d3594a6f9d > > Author: hjl > > Date: Thu Aug 10 15:29:05 2017 + > > > > i3