Re: [PATCH] x86: Don't use get_frame_size to finalize stack frame

2018-12-16 Thread Uros Bizjak
On 12/15/18, H.J. Lu wrote: > On Fri, Dec 14, 2018 at 04:04:02PM -0800, H.J. Lu wrote: >> On Fri, Dec 14, 2018 at 3:24 PM Jeff Law wrote: >> > >> > On 12/14/18 4:01 PM, H.J. Lu wrote: >> > > On Thu, Dec 13, 2018 at 11:11 PM Uros Bizjak >> > > wrote: >> > >> On Thu, Dec 13, 2018 at 6:36 PM H.J. L

Re: [PATCH] x86: Don't use get_frame_size to finalize stack frame

2018-12-15 Thread H.J. Lu
On Fri, Dec 14, 2018 at 04:04:02PM -0800, H.J. Lu wrote: > On Fri, Dec 14, 2018 at 3:24 PM Jeff Law wrote: > > > > On 12/14/18 4:01 PM, H.J. Lu wrote: > > > On Thu, Dec 13, 2018 at 11:11 PM Uros Bizjak wrote: > > >> On Thu, Dec 13, 2018 at 6:36 PM H.J. Lu wrote: > > >>> get_frame_size () returns

Re: [PATCH] x86: Don't use get_frame_size to finalize stack frame

2018-12-14 Thread H.J. Lu
On Fri, Dec 14, 2018 at 3:24 PM Jeff Law wrote: > > On 12/14/18 4:01 PM, H.J. Lu wrote: > > On Thu, Dec 13, 2018 at 11:11 PM Uros Bizjak wrote: > >> On Thu, Dec 13, 2018 at 6:36 PM H.J. Lu wrote: > >>> get_frame_size () returns used stack slots during compilation, which > >>> may be optimized ou

Re: [PATCH] x86: Don't use get_frame_size to finalize stack frame

2018-12-14 Thread Jeff Law
On 12/14/18 4:01 PM, H.J. Lu wrote: > On Thu, Dec 13, 2018 at 11:11 PM Uros Bizjak wrote: >> On Thu, Dec 13, 2018 at 6:36 PM H.J. Lu wrote: >>> get_frame_size () returns used stack slots during compilation, which >>> may be optimized out later. Since ix86_find_max_used_stack_alignment >>> is cal

Re: [PATCH] x86: Don't use get_frame_size to finalize stack frame

2018-12-14 Thread H.J. Lu
On Thu, Dec 13, 2018 at 11:11 PM Uros Bizjak wrote: > > On Thu, Dec 13, 2018 at 6:36 PM H.J. Lu wrote: > > > > get_frame_size () returns used stack slots during compilation, which > > may be optimized out later. Since ix86_find_max_used_stack_alignment > > is called by ix86_finalize_stack_frame_

Re: [PATCH] x86: Don't use get_frame_size to finalize stack frame

2018-12-13 Thread Uros Bizjak
On Thu, Dec 13, 2018 at 6:36 PM H.J. Lu wrote: > > get_frame_size () returns used stack slots during compilation, which > may be optimized out later. Since ix86_find_max_used_stack_alignment > is called by ix86_finalize_stack_frame_flags to check if stack frame > is required, there is no need to

[PATCH] x86: Don't use get_frame_size to finalize stack frame

2018-12-13 Thread H.J. Lu
get_frame_size () returns used stack slots during compilation, which may be optimized out later. Since ix86_find_max_used_stack_alignment is called by ix86_finalize_stack_frame_flags to check if stack frame is required, there is no need to call get_frame_size () which may give inaccurate final sta