Re: [PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Uros Bizjak via Gcc-patches
On Mon, Nov 9, 2020 at 2:50 PM Hongyu Wang wrote: LGTM. Thanks, Uros. > > > > Please rewrite scan strings back to using double-quotation marks. > > > > Yes, updated patch. > > Uros Bizjak 于2020年11月9日周一 下午7:41写道： > > > > > On Mon, Nov 9, 2020 at 11:50 AM Hongyu Wang wrote: > > > > > > Hi > > >

Re: [PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Hongyu Wang via Gcc-patches
> > Please rewrite scan strings back to using double-quotation marks. > Yes, updated patch. Uros Bizjak 于2020年11月9日周一 下午7:41写道： > > On Mon, Nov 9, 2020 at 11:50 AM Hongyu Wang wrote: > > > > Hi > > > > According to the discussion in > > https://gcc.gnu.org/pipermail/gcc/2020-November/234096.ht

Re: [PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Andreas Schwab
On Nov 09 2020, Hongyu Wang via Gcc-patches wrote: > diff --git a/gcc/testsuite/gcc.target/i386/keylocker-encodekey128.c > b/gcc/testsuite/gcc.target/i386/keylocker-encodekey128.c > index 8dd1bc634ac..c2bc7ea344d 100644 > --- a/gcc/testsuite/gcc.target/i386/keylocker-encodekey128.c > +++ b/gcc/te

Re: [PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Uros Bizjak via Gcc-patches
On Mon, Nov 9, 2020 at 12:47 PM Iain Sandoe wrote: > > Uros Bizjak via Gcc-patches wrote: > > > On Mon, Nov 9, 2020 at 11:50 AM Hongyu Wang wrote: > >> Hi > >> > >> According to the discussion in > >> https://gcc.gnu.org/pipermail/gcc/2020-November/234096.html, > >> The testcase for keylocker-*

Re: [PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Iain Sandoe via Gcc-patches
Uros Bizjak via Gcc-patches wrote: On Mon, Nov 9, 2020 at 11:50 AM Hongyu Wang wrote: Hi According to the discussion in https://gcc.gnu.org/pipermail/gcc/2020-November/234096.html, The testcase for keylocker-* is too strict for darwin target. This patch adjusted the regex, and add a missing

Re: [PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Uros Bizjak via Gcc-patches
On Mon, Nov 9, 2020 at 11:50 AM Hongyu Wang wrote: > > Hi > > According to the discussion in > https://gcc.gnu.org/pipermail/gcc/2020-November/234096.html, > The testcase for keylocker-* is too strict for darwin target. This > patch adjusted the regex, and add a missing test for aesenc256kl > inst

[PATCH] x86: Adjust keylocker testcases for fail on darwin

2020-11-09 Thread Hongyu Wang via Gcc-patches
Hi According to the discussion in https://gcc.gnu.org/pipermail/gcc/2020-November/234096.html, The testcase for keylocker-* is too strict for darwin target. This patch adjusted the regex, and add a missing test for aesenc256kl instruction. Tested by Iain Sandone and all get pass in darwin target.