Re: [PATCH] tree-optimization/98211 - fix bogus vectorization of conversion

2020-12-11 Thread Richard Biener
On December 11, 2020 2:49:07 PM GMT+01:00, Richard Sandiford wrote: >Richard Biener writes: >> On Fri, 11 Dec 2020, Richard Sandiford wrote: >> >>> Richard Biener writes: >>> > On Fri, 11 Dec 2020, Richard Sandiford wrote: >>> >> > diff --git a/gcc/tree-vect-stmts.c b/gcc/tree-vect-stmts.c >>>

Re: [PATCH] tree-optimization/98211 - fix bogus vectorization of conversion

2020-12-11 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > On Fri, 11 Dec 2020, Richard Sandiford wrote: > >> Richard Biener writes: >> > On Fri, 11 Dec 2020, Richard Sandiford wrote: >> >> > diff --git a/gcc/tree-vect-stmts.c b/gcc/tree-vect-stmts.c >> >> > index a4980a931a9..d3ab8aa1c29 100644 >> >> > --- a/gcc/tree-vect-stmts.

Re: [PATCH] tree-optimization/98211 - fix bogus vectorization of conversion

2020-12-11 Thread Richard Biener
On Fri, 11 Dec 2020, Richard Sandiford wrote: > Richard Biener writes: > > On Fri, 11 Dec 2020, Richard Sandiford wrote: > >> > diff --git a/gcc/tree-vect-stmts.c b/gcc/tree-vect-stmts.c > >> > index a4980a931a9..d3ab8aa1c29 100644 > >> > --- a/gcc/tree-vect-stmts.c > >> > +++ b/gcc/tree-vect-stm

Re: [PATCH] tree-optimization/98211 - fix bogus vectorization of conversion

2020-12-11 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > On Fri, 11 Dec 2020, Richard Sandiford wrote: >> > diff --git a/gcc/tree-vect-stmts.c b/gcc/tree-vect-stmts.c >> > index a4980a931a9..d3ab8aa1c29 100644 >> > --- a/gcc/tree-vect-stmts.c >> > +++ b/gcc/tree-vect-stmts.c >> > @@ -5123,6 +5123,17 @@ vectorizable_assignment (v

Re: [PATCH] tree-optimization/98211 - fix bogus vectorization of conversion

2020-12-11 Thread Richard Biener
On Fri, 11 Dec 2020, Richard Sandiford wrote: > Richard Biener writes: > > Pattern recog incompletely handles some bool cases but we shouldn't > > miscompile as a result but not vectorize. Unfortunately > > vectorizable_assignment lets invalid conversions (that > > vectorizable_conversion reject

Re: [PATCH] tree-optimization/98211 - fix bogus vectorization of conversion

2020-12-11 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > Pattern recog incompletely handles some bool cases but we shouldn't > miscompile as a result but not vectorize. Unfortunately > vectorizable_assignment lets invalid conversions (that > vectorizable_conversion rejects) slip through. The following > rectifies that. > > Boo

[PATCH] tree-optimization/98211 - fix bogus vectorization of conversion

2020-12-10 Thread Richard Biener
Pattern recog incompletely handles some bool cases but we shouldn't miscompile as a result but not vectorize. Unfortunately vectorizable_assignment lets invalid conversions (that vectorizable_conversion rejects) slip through. The following rectifies that. Bootstrapped and tested on x86_64-unknow