Re: [PATCH] tree-optimization/114855 - speed up dom_oracle::register_transitives

2024-09-26 Thread Richard Biener
On Thu, 26 Sep 2024, Andrew MacLeod wrote: > > On 9/26/24 10:03, Andrew MacLeod wrote: > > > > On 9/26/24 03:07, Richard Biener wrote: > >> On Wed, 25 Sep 2024, Andrew MacLeod wrote: > >> > >>> > >>> > >>> I added a note to the PR before I saw this... we can just disable > >>> transitives > >>> w

Re: [PATCH] tree-optimization/114855 - speed up dom_oracle::register_transitives

2024-09-26 Thread Andrew MacLeod
On 9/26/24 10:03, Andrew MacLeod wrote: On 9/26/24 03:07, Richard Biener wrote: On Wed, 25 Sep 2024, Andrew MacLeod wrote: I added a note to the PR before I saw this... we can just disable transitives when the graph gets too big... I don't think they are worth the expense when things ge

Re: [PATCH] tree-optimization/114855 - speed up dom_oracle::register_transitives

2024-09-26 Thread Andrew MacLeod
eory anyway. Anyway, I'm re-testing the following revised version and will install it. Thanks, Richard. From 48fb0382d23ad6c58ca7573965843509828a07e8 Mon Sep 17 00:00:00 2001 From: Richard Biener Date: Wed, 25 Sep 2024 10:38:12 +0200 Subject: [PATCH] tree-optimization/114855 - speed

Re: [PATCH] tree-optimization/114855 - speed up dom_oracle::register_transitives

2024-09-26 Thread Richard Biener
ensive-optimizations, so we maybe want to use that to default transitives but I'm also thinking whether it's possible to restrict DOMs ranger processing to global ranges? DOM does enable_ranger () and not just it's range-query so I'm not sure I can easily subsitute global range que

Re: [PATCH] tree-optimization/114855 - speed up dom_oracle::register_transitives

2024-09-25 Thread Andrew MacLeod
On 9/25/24 06:51, Richard Biener wrote: dom_oracle::register_transitives contains an unbound dominator walk which for the testcase in PR114855 dominates the profile. I've also noticed odd behavior in the case when set_one_relation returns NULL, we'd then completely abort processing other relati

[PATCH] tree-optimization/114855 - speed up dom_oracle::register_transitives

2024-09-25 Thread Richard Biener
dom_oracle::register_transitives contains an unbound dominator walk which for the testcase in PR114855 dominates the profile. I've also noticed odd behavior in the case when set_one_relation returns NULL, we'd then completely abort processing other relations. The following fixes the latter by con