Re: [PATCH] tree-optimization/106593 - fix ICE with backward threading

2022-08-15 Thread Richard Biener via Gcc-patches
On Fri, 12 Aug 2022, Andrew MacLeod wrote: > > On 8/12/22 07:31, Aldy Hernandez wrote: > > On Fri, Aug 12, 2022 at 12:59 PM Richard Biener wrote: > >> With the last re-org I failed to make sure to not add SSA names > >> nor supported by ranger into m_imports which then triggers an > >> ICE in ra

Re: [PATCH] tree-optimization/106593 - fix ICE with backward threading

2022-08-12 Thread Aldy Hernandez via Gcc-patches
On Fri, Aug 12, 2022 at 1:36 PM Richard Biener wrote: > > On Fri, 12 Aug 2022, Aldy Hernandez wrote: > > > On Fri, Aug 12, 2022 at 12:59 PM Richard Biener wrote: > > > > > > With the last re-org I failed to make sure to not add SSA names > > > nor supported by ranger into m_imports which then tri

Re: [PATCH] tree-optimization/106593 - fix ICE with backward threading

2022-08-12 Thread Aldy Hernandez via Gcc-patches
In that case Richi, go right ahead with your original patch. I for one am happy we can use range_on_entry, which always seemed cleaner. Aldy On Fri, Aug 12, 2022, 16:07 Andrew MacLeod wrote: > > On 8/12/22 09:38, Andrew MacLeod wrote: > > > > On 8/12/22 07:31, Aldy Hernandez wrote: > >> On Fri,

Re: [PATCH] tree-optimization/106593 - fix ICE with backward threading

2022-08-12 Thread Andrew MacLeod via Gcc-patches
On 8/12/22 09:38, Andrew MacLeod wrote: On 8/12/22 07:31, Aldy Hernandez wrote: On Fri, Aug 12, 2022 at 12:59 PM Richard Biener wrote: With the last re-org I failed to make sure to not add SSA names nor supported by ranger into m_imports which then triggers an ICE in range_on_path_entry bec

Re: [PATCH] tree-optimization/106593 - fix ICE with backward threading

2022-08-12 Thread Andrew MacLeod via Gcc-patches
On 8/12/22 07:31, Aldy Hernandez wrote: On Fri, Aug 12, 2022 at 12:59 PM Richard Biener wrote: With the last re-org I failed to make sure to not add SSA names nor supported by ranger into m_imports which then triggers an ICE in range_on_path_entry because range_of_expr returns false. I've no

Re: [PATCH] tree-optimization/106593 - fix ICE with backward threading

2022-08-12 Thread Richard Biener via Gcc-patches
On Fri, 12 Aug 2022, Aldy Hernandez wrote: > On Fri, Aug 12, 2022 at 12:59 PM Richard Biener wrote: > > > > With the last re-org I failed to make sure to not add SSA names > > nor supported by ranger into m_imports which then triggers an > > ICE in range_on_path_entry because range_of_expr return

Re: [PATCH] tree-optimization/106593 - fix ICE with backward threading

2022-08-12 Thread Aldy Hernandez via Gcc-patches
On Fri, Aug 12, 2022 at 12:59 PM Richard Biener wrote: > > With the last re-org I failed to make sure to not add SSA names > nor supported by ranger into m_imports which then triggers an > ICE in range_on_path_entry because range_of_expr returns false. I've > noticed that range_on_path_entry does

[PATCH] tree-optimization/106593 - fix ICE with backward threading

2022-08-12 Thread Richard Biener via Gcc-patches
With the last re-org I failed to make sure to not add SSA names nor supported by ranger into m_imports which then triggers an ICE in range_on_path_entry because range_of_expr returns false. I've noticed that range_on_path_entry does mightly complicated things that don't make sense to me and the co