Re: [PATCH] tree-optimization/106514 - revisit m_import compute in backward threading

2022-08-15 Thread Richard Biener via Gcc-patches
On Thu, 11 Aug 2022, Andrew MacLeod wrote: > > On 8/10/22 06:46, Richard Biener wrote: > > > > I see the solver itself adds relations from edges on the path so > > the cruical item here seems to be to add imports for the path > > entry conditional, but those would likely be GORI imports for that

Re: [PATCH] tree-optimization/106514 - revisit m_import compute in backward threading

2022-08-11 Thread Andrew MacLeod via Gcc-patches
On 8/10/22 06:46, Richard Biener wrote: I see the solver itself adds relations from edges on the path so the cruical item here seems to be to add imports for the path entry conditional, but those would likely be GORI imports for that block? Unfortunately that fails to add t[012], the GORI exp

Re: [PATCH] tree-optimization/106514 - revisit m_import compute in backward threading

2022-08-10 Thread Aldy Hernandez via Gcc-patches
On Wed, Aug 10, 2022 at 12:46 PM Richard Biener wrote: > > On Wed, 10 Aug 2022, Richard Biener wrote: > > > On Tue, 9 Aug 2022, Andrew MacLeod wrote: > > > > > > > > On 8/9/22 09:01, Richard Biener wrote: > > > > This revisits how we compute imports later used for the ranger path > > > > query dur

Re: [PATCH] tree-optimization/106514 - revisit m_import compute in backward threading

2022-08-10 Thread Aldy Hernandez via Gcc-patches
I'm still on vacation, but I figured I'd mention a few things to either unblock you, or move the conversation along. On Wed, Aug 10, 2022 at 8:45 AM Richard Biener wrote: > > On Tue, 9 Aug 2022, Andrew MacLeod wrote: > > > > > On 8/9/22 09:01, Richard Biener wrote: > > > This revisits how we comp

Re: [PATCH] tree-optimization/106514 - revisit m_import compute in backward threading

2022-08-10 Thread Richard Biener via Gcc-patches
On Wed, 10 Aug 2022, Richard Biener wrote: > On Tue, 9 Aug 2022, Andrew MacLeod wrote: > > > > > On 8/9/22 09:01, Richard Biener wrote: > > > This revisits how we compute imports later used for the ranger path > > > query during backwards threading. The compute_imports function > > > of the pat

Re: [PATCH] tree-optimization/106514 - revisit m_import compute in backward threading

2022-08-09 Thread Richard Biener via Gcc-patches
On Tue, 9 Aug 2022, Andrew MacLeod wrote: > > On 8/9/22 09:01, Richard Biener wrote: > > This revisits how we compute imports later used for the ranger path > > query during backwards threading. The compute_imports function > > of the path solver ends up pulling the SSA def chain of regular > >

Re: [PATCH] tree-optimization/106514 - revisit m_import compute in backward threading

2022-08-09 Thread Andrew MacLeod via Gcc-patches
On 8/9/22 09:01, Richard Biener wrote: This revisits how we compute imports later used for the ranger path query during backwards threading. The compute_imports function of the path solver ends up pulling the SSA def chain of regular stmts without limit and since it starts with just the gori i

[PATCH] tree-optimization/106514 - revisit m_import compute in backward threading

2022-08-09 Thread Richard Biener via Gcc-patches
This revisits how we compute imports later used for the ranger path query during backwards threading. The compute_imports function of the path solver ends up pulling the SSA def chain of regular stmts without limit and since it starts with just the gori imports of the path exit it misses some inte