Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-07-26 Thread Maciej W. Rozycki
On Mon, 26 Jul 2021, Richard Sandiford wrote: > >> Sorry, somehow I didn't see Richard's reply.  Perhaps a > >> misconfiguration > >> on my mail server. > > I don't know where the problem lies, but for some reason I've been > getting rejects when sending messages directly (via reply-all). Somet

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-07-26 Thread Richard Sandiford via Gcc-patches
Xi Ruoyao writes: > On Fri, 2021-07-23 at 11:18 +0800, Xi Ruoyao wrote: >> On Fri, 2021-07-23 at 04:21 +0200, Maciej W. Rozycki wrote: >> > On Fri, 9 Jul 2021, Richard Sandiford via Gcc-patches wrote: >> > >> > > > > > > The "smallest fix" is simply adding -fno-inline into >> > > > > > > mips.exp

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-07-22 Thread Xi Ruoyao via Gcc-patches
On Fri, 2021-07-23 at 11:18 +0800, Xi Ruoyao wrote: > On Fri, 2021-07-23 at 04:21 +0200, Maciej W. Rozycki wrote: > > On Fri, 9 Jul 2021, Richard Sandiford via Gcc-patches wrote: > > > > > > > > > The "smallest fix" is simply adding -fno-inline into > > > > > > > mips.exp.  > > > > > > > However >

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-07-22 Thread Xi Ruoyao via Gcc-patches
On Fri, 2021-07-23 at 04:21 +0200, Maciej W. Rozycki wrote: > On Fri, 9 Jul 2021, Richard Sandiford via Gcc-patches wrote: > > > > > > > The "smallest fix" is simply adding -fno-inline into > > > > > > mips.exp.  > > > > > > However > > > > > > I don't like it because I agree with you that mips.ex

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-07-22 Thread Maciej W. Rozycki
On Fri, 9 Jul 2021, Richard Sandiford via Gcc-patches wrote: > >> > > The "smallest fix" is simply adding -fno-inline into mips.exp.  > >> > > However > >> > > I don't like it because I agree with you that mips.exp shouldn't > >> > > care > >> > > about dg-options, at least don't do it too much. >

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-07-09 Thread Richard Sandiford via Gcc-patches
Xi Ruoyao writes: > On Thu, 2021-07-08 at 17:44 -0600, Jeff Law wrote: >> >> >> On 6/25/2021 8:40 AM, Richard Sandiford wrote: >> > Xi Ruoyao via Gcc-patches writes: >> > > On Fri, 2021-06-25 at 01:02 +0800, Xi Ruoyao wrote: >> > > > On Thu, 2021-06-24 at 10:48 -0600, Jeff Law wrote: >> > > > >

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-07-08 Thread Xi Ruoyao via Gcc-patches
On Thu, 2021-07-08 at 17:44 -0600, Jeff Law wrote: > > > On 6/25/2021 8:40 AM, Richard Sandiford wrote: > > Xi Ruoyao via Gcc-patches writes: > > > On Fri, 2021-06-25 at 01:02 +0800, Xi Ruoyao wrote: > > > > On Thu, 2021-06-24 at 10:48 -0600, Jeff Law wrote: > > > > > I'd like to know a bit more

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-07-08 Thread Jeff Law via Gcc-patches
On 6/25/2021 8:40 AM, Richard Sandiford wrote: Xi Ruoyao via Gcc-patches writes: On Fri, 2021-06-25 at 01:02 +0800, Xi Ruoyao wrote: On Thu, 2021-06-24 at 10:48 -0600, Jeff Law wrote: I'd like to know a bit more here.  mips.exp shouldn't care about the options passed to the compiler and to

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-06-25 Thread Richard Sandiford via Gcc-patches
Xi Ruoyao via Gcc-patches writes: > On Fri, 2021-06-25 at 01:02 +0800, Xi Ruoyao wrote: >> On Thu, 2021-06-24 at 10:48 -0600, Jeff Law wrote: >> > I'd like to know a bit more here.  mips.exp shouldn't care about the >> > options passed to the compiler and to the best of my knowledge >> > patch it

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-06-25 Thread Xi Ruoyao via Gcc-patches
On Fri, 2021-06-25 at 01:02 +0800, Xi Ruoyao wrote: > On Thu, 2021-06-24 at 10:48 -0600, Jeff Law wrote: > > I'd like to know a bit more here.  mips.exp shouldn't care about the > > options passed to the compiler and to the best of my knowledge > > patch itself is wrong, I question if it's necessa

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-06-25 Thread Richard Sandiford via Gcc-patches
Xi Ruoyao via Gcc-patches writes: > On Thu, 2021-06-24 at 10:48 -0600, Jeff Law wrote: >> >> >> On 6/22/2021 1:05 AM, Xi Ruoyao via Gcc-patches wrote: >> > mips.exp does not support -fno-inline, causing the tests return >> > "ERROR: >> > Unrecognised option: -fno-inline for dg-options ... ". >>

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-06-24 Thread Xi Ruoyao via Gcc-patches
On Thu, 2021-06-24 at 10:48 -0600, Jeff Law wrote: > > > On 6/22/2021 1:05 AM, Xi Ruoyao via Gcc-patches wrote: > > mips.exp does not support -fno-inline, causing the tests return > > "ERROR: > > Unrecognised option: -fno-inline for dg-options ... ". > > > > Use noinline attribute like other mip

Re: [PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-06-24 Thread Jeff Law via Gcc-patches
On 6/22/2021 1:05 AM, Xi Ruoyao via Gcc-patches wrote: mips.exp does not support -fno-inline, causing the tests return "ERROR: Unrecognised option: -fno-inline for dg-options ... ". Use noinline attribute like other mips target tests, to workaround it. gcc/testsuite/ * gcc.target/mi

[PATCH] testsuite: mips: use noinline attribute instead of -fno-inline

2021-06-22 Thread Xi Ruoyao via Gcc-patches
mips.exp does not support -fno-inline, causing the tests return "ERROR: Unrecognised option: -fno-inline for dg-options ... ". Use noinline attribute like other mips target tests, to workaround it. gcc/testsuite/ * gcc.target/mips/cfgcleanup-jalr2.c: Remove -fno-inline and add