Re: [PATCH] testsuite: libitm: Adjust how libitm.c++ passes link flags

Reading Lewis' patch and the original patch a bit more carefully I think the patch I suggested should have used `additional_flags` instead of `ldflags`. Outside of that -- would any maintainer on Cc be OK with one of our patches going in? On 1/3/25 22:05, Lewis Hyatt wrote: External email:

Re: [PATCH] testsuite: libitm: Adjust how libitm.c++ passes link flags

On Fri, Jan 03, 2025 at 05:48:12PM +, Matthew Malcomson wrote: > On 1/3/25 17:14, Joseph Myers wrote: > > Does this patch cover everything dealt with by > > > > ([PATCH] testsuite: libitm: Remove build directory path from tes

Re: [PATCH] testsuite: libitm: Adjust how libitm.c++ passes link flags

Ah -- I didn't notice that patch. It looks like both do essentially the same thing. That one identifies the use of the c++ test runner by checking for the presence of the `lang_test_file` variable, and in that case `libitm_target_compile` adds the options, while in my patch the c++ test runne

Re: [PATCH] testsuite: libitm: Adjust how libitm.c++ passes link flags

Does this patch cover everything dealt with by ([PATCH] testsuite: libitm: Remove build directory path from test names), or would some separate fix for that issue still be needed in the presence of this patch? -- Joseph S.

Re: [PATCH] testsuite: libitm: Adjust how libitm.c++ passes link flags

f71221 Mon Sep 17 00:00:00 2001 From: Matthew Malcomson Date: Wed, 11 Dec 2024 11:03:55 + Subject: [PATCH] testsuite: libitm: Adjust how libitm.c++ passes link flags For the `gcc` and `g++` tools we often pass -B/path/to/object/dir in via `TEST_ALWAYS_FLAGS` (see e.g. asan.exp where this is

Re: [PATCH] testsuite: libitm: Adjust how libitm.c++ passes link flags

a way of handling this without the second variable would be to make libitm_finish check whether TEST_ALWAYS_FLAGS is set. If it isn't, then it must be the second call to libitm_finish. OK that way if you agree, or OK as-is if you think it's better. Richard > Have attached the adju

Re: [PATCH] testsuite: libitm: Adjust how libitm.c++ passes link flags

17 00:00:00 2001 From: Matthew Malcomson Date: Wed, 11 Dec 2024 11:03:55 +0000 Subject: [PATCH] testsuite: libitm: Adjust how libitm.c++ passes link flags For the `gcc` and `g++` tools we often pass -B/path/to/object/dir in via `TEST_ALWAYS_FLAGS` (see e.g. asan.exp where this is set). In

Re: [PATCH] testsuite: libitm: Adjust how libitm.c++ passes link flags

writes: > From: Matthew Malcomson > > For the `gcc` and `g++` tools we often pass -B/path/to/object/dir in via > `TEST_ALWAYS_FLAGS` (see e.g. asan.exp where this is set). > In libitm.c++/c++.exp we pass that -B flag via the `tool_flags` argument > to `dg-runtest`. > > Passing as the `tool_flags`

[PATCH] testsuite: libitm: Adjust how libitm.c++ passes link flags

From: Matthew Malcomson For the `gcc` and `g++` tools we often pass -B/path/to/object/dir in via `TEST_ALWAYS_FLAGS` (see e.g. asan.exp where this is set). In libitm.c++/c++.exp we pass that -B flag via the `tool_flags` argument to `dg-runtest`. Passing as the `tool_flags` argument means that th