Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-18 Thread Mike Stump
On Apr 10, 2025, at 6:38 AM, Christophe Lyon wrote: > > On Thu, 10 Apr 2025 at 15:29, Hans-Peter Nilsson wrote: >> >>> From: Christophe Lyon >>> Date: Thu, 10 Apr 2025 15:21:23 +0200 >> >> Not sure why I'm CC:ed on this one, not being a maintainer >> of the testsuite or targets where gcov tes

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-16 Thread Christophe Lyon
On Wed, 16 Apr 2025 at 16:14, Hans-Peter Nilsson wrote: > > > From: Christophe Lyon > > Date: Wed, 16 Apr 2025 14:41:17 +0200 > > > ping? > > Since you directed it at me and CC:ed the list; in case that > was deliberate: I can only repeat "still ok", but I don't > have approval rights to the test

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-16 Thread Hans-Peter Nilsson
> From: Christophe Lyon > Date: Wed, 16 Apr 2025 14:41:17 +0200 > ping? Since you directed it at me and CC:ed the list; in case that was deliberate: I can only repeat "still ok", but I don't have approval rights to the testsuite parts. > > On Thu, 10 Apr 2025 at 15:48, Hans-Peter Nilsson wrot

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-16 Thread Christophe Lyon
ping? On Thu, 10 Apr 2025 at 15:48, Hans-Peter Nilsson wrote: > > > From: Christophe Lyon > > Date: Thu, 10 Apr 2025 15:38:48 +0200 > > > On Thu, 10 Apr 2025 at 15:29, Hans-Peter Nilsson wrote: > > > > > > > From: Christophe Lyon > > > > Date: Thu, 10 Apr 2025 15:21:23 +0200 > > > > > > Not su

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Christophe Lyon
On Thu, 10 Apr 2025 at 15:29, Hans-Peter Nilsson wrote: > > > From: Christophe Lyon > > Date: Thu, 10 Apr 2025 15:21:23 +0200 > > Not sure why I'm CC:ed on this one, not being a maintainer > of the testsuite or targets where gcov tests are exercised, Because you fixed a problem in r13-4103-ge91d

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Hans-Peter Nilsson
> From: Christophe Lyon > Date: Thu, 10 Apr 2025 15:38:48 +0200 > On Thu, 10 Apr 2025 at 15:29, Hans-Peter Nilsson wrote: > > > > > From: Christophe Lyon > > > Date: Thu, 10 Apr 2025 15:21:23 +0200 > > > > Not sure why I'm CC:ed on this one, not being a maintainer > > of the testsuite or target

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Hans-Peter Nilsson
> From: Christophe Lyon > Date: Thu, 10 Apr 2025 15:21:23 +0200 Not sure why I'm CC:ed on this one, not being a maintainer of the testsuite or targets where gcov tests are exercised, but FWIW: LGTM except for the two nits: > ping? > > On Tue, 1 Apr 2025 at 22:37, Christophe Lyon > wrote: > >

Re: [PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-10 Thread Christophe Lyon
ping? On Tue, 1 Apr 2025 at 22:37, Christophe Lyon wrote: > > After commit r15-8947-g8ed2d5d219e999, which added new tests using > gcov, the CI noticed failures because it was calling 'gcov' instead of > $target-gcov. > > This is because the CI scripts override GXX_UNDER_TEST, but still run > the

[PATCH] testsuite: Add support for GCOV_UNDER_TEST

2025-04-01 Thread Christophe Lyon
After commit r15-8947-g8ed2d5d219e999, which added new tests using gcov, the CI noticed failures because it was calling 'gcov' instead of $target-gcov. This is because the CI scripts override GXX_UNDER_TEST, but still run the testsuite in-tree, and gcc-transform-out-of-tree only depends on TESTING