On 28/09/17 11:50 +0100, Jonathan Wakely wrote:
On 21/09/17 07:46 +0200, François Dumont wrote:
Gentle reminder, ok to commit ?
No. Could you and Petr please come to an agreement about what is
actually wrong with the current implementation, and agree on a
solution?
Currently you're both just
On 21/09/17 07:46 +0200, François Dumont wrote:
Gentle reminder, ok to commit ?
No. Could you and Petr please come to an agreement about what is
actually wrong with the current implementation, and agree on a
solution?
Currently you're both just proposing patches that do different things,
witho
Gentle reminder, ok to commit ?
* include/bits/streambuf_iterator.h
(istreambuf_iterator<>(const istreambuf_iterator&)): Remove useless
noexcept qualificatio::operator*()): Do not capture iterator state
in Debug assertion.
(istreambuf_iterator<>::operator++()): Likewise.
(
Hi
Completing the execution of tests revealed a lot about the current
implementation.
The main point of current implementation is to delay as much as
possible the capture of the current streambuf position. So my original
proposal capturing state on instantiation was wrong.
This
-gcc-patches
On Thu, 7 Sep 2017 23:02:15 +0200
François Dumont wrote:
> + _M_c = _M_sbuf->sgetc();
> + if (_S_at_eof(_M_c))
> + _M_sbuf = 0;
_M_sbuf = 0; <--- Is not what I axpect here.
Suggestions will be later, after we finish copyright assignment for
changes procedure (in pro
Hi
Following this report I had a closer look to this debug-dependent
behavior which I agree about.
I have added some checks to 2.cc as shown in the patch. Initially the
test was failing because:
/home/fdt/dev/gcc/git/libstdc++-v3/testsuite/24_iterators/istreambuf_iterator/2.cc:45:
void test0
On 24/08/17 12:57 +0300, Petr Ovtchenkov wrote:
Explicit do sgetc from associated streambuf. Avoid debug-dependent
sgetc (within _M_at_eof()):
__glibcxx_requires_cond(!_M_at_eof(),
_M_message(__gnu_debug::__msg_inc_istreambuf)
._M
Explicit do sgetc from associated streambuf. Avoid debug-dependent
sgetc (within _M_at_eof()):
__glibcxx_requires_cond(!_M_at_eof(),
_M_message(__gnu_debug::__msg_inc_istreambuf)
._M_iterator(*this));
Increment operators not req
