Re: [PATCH] ssa-ifcombine: combining comparisons [Bug 53806]

2021-03-10 Thread Richard Biener via Gcc-patches
On Tue, Mar 9, 2021 at 9:57 PM Ivan Sučić wrote: > > Richard Biener wrote: > >I don't think removing all code is OK since it would > >allow combining x == y || x > y to x >= y which may > >trap. The bugreport suggests to alter the last > >test to something like > > > > if (trap && !ltrap && !rtra

Re: [PATCH] ssa-ifcombine: combining comparisons [Bug 53806]

2021-03-09 Thread Ivan Sučić via Gcc-patches
Richard Biener wrote: >I don't think removing all code is OK since it would >allow combining x == y || x > y to x >= y which may >trap. The bugreport suggests to alter the last >test to something like > > if (trap && !ltrap && !rtrap) > return NULL_TREE; > >thus if we manage to remove a trap (!tra

Re: [PATCH] ssa-ifcombine: combining comparisons [Bug 53806]

2021-03-04 Thread Richard Biener via Gcc-patches
On Thu, Mar 4, 2021 at 1:23 AM Ivan Sučić via Gcc-patches wrote: > > Hi, > The patch solves the bug when in ifcombine are comparisons like <= and >= > combined. I removed the trap check for last statement and that doesn't break > the solution for bug 61383. In fold-const.c i removed the trap che