Re: [PATCH] simplify-rtx.c: Change BITSIZE to UNIT_PRECISION in simplification

2019-07-03 Thread John Darrington
On Wed, Jul 03, 2019 at 04:32:54PM -0600, Jeff Law wrote: John, I assume you're doing this for an out of tree port (s12z?)? That is correct. Otherwise it'd also be useful if you could include a test which triggers the assert. Once I have the other aspects of the port sorted out I

Re: [PATCH] simplify-rtx.c: Change BITSIZE to UNIT_PRECISION in simplification

2019-07-03 Thread Jeff Law
On 7/3/19 2:17 PM, Richard Sandiford wrote: >> diff --git a/gcc/simplify-rtx.c b/gcc/simplify-rtx.c >> index 89a46a9..d74a4ba 100644 >> --- a/gcc/simplify-rtx.c >> +++ b/gcc/simplify-rtx.c >> @@ -1504,12 +1504,12 @@ simplify_unary_operation_1 (enum rtx_code code, >> machine_mode mode, rtx op) >>

Re: [PATCH] simplify-rtx.c: Change BITSIZE to UNIT_PRECISION in simplification

2019-07-03 Thread Richard Sandiford
> diff --git a/gcc/simplify-rtx.c b/gcc/simplify-rtx.c > index 89a46a9..d74a4ba 100644 > --- a/gcc/simplify-rtx.c > +++ b/gcc/simplify-rtx.c > @@ -1504,12 +1504,12 @@ simplify_unary_operation_1 (enum rtx_code code, > machine_mode mode, rtx op) > && CONST_INT_P (XEXP (op, 1)) > && X

[PATCH] simplify-rtx.c: Change BITSIZE to UNIT_PRECISION in simplification of (extend ashiftrt (ashift ..))) Otherwise the gcc_assert can catch when dealing with partial int modes.

2019-07-03 Thread John Darrington
--- gcc/ChangeLog | 6 ++ gcc/simplify-rtx.c | 8 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c206ab6..47035ca 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2019-07-03 John Darrington + + simplify-r