Re: [PATCH] simplify-rtx: Remove non-simplifying simplification (PR77729)

2017-10-05 Thread Segher Boessenkool
On Thu, Oct 05, 2017 at 10:46:13AM +0200, Richard Biener wrote: > >> PR rtl-optimization/77729 > >> * simplify-rtx.c (simplify_binary_operation_1): Delete the (X&C1)|C2 > >> to (X&(C1&~C2))|C2 transformations. > > OK for the trunk. I'm not sure if the BZ in question qualifies thi

Re: [PATCH] simplify-rtx: Remove non-simplifying simplification (PR77729)

2017-10-05 Thread Richard Biener
On Tue, Oct 3, 2017 at 12:40 AM, Jeff Law wrote: > On 10/02/2017 01:35 PM, Segher Boessenkool wrote: >> If we have (X&C1)|C2 simplify_binary_operation_1 makes C1 as small as >> possible. This makes worse code in common cases like when the AND with >> C1 is from a zero-extension. This patch fixes

Re: [PATCH] simplify-rtx: Remove non-simplifying simplification (PR77729)

2017-10-02 Thread Jeff Law
On 10/02/2017 01:35 PM, Segher Boessenkool wrote: > If we have (X&C1)|C2 simplify_binary_operation_1 makes C1 as small as > possible. This makes worse code in common cases like when the AND with > C1 is from a zero-extension. This patch fixes it by removing this > transformation (twice). > > I t

[PATCH] simplify-rtx: Remove non-simplifying simplification (PR77729)

2017-10-02 Thread Segher Boessenkool
If we have (X&C1)|C2 simplify_binary_operation_1 makes C1 as small as possible. This makes worse code in common cases like when the AND with C1 is from a zero-extension. This patch fixes it by removing this transformation (twice). I tested this on 31 targets, also some variations that do the tra