Re: [PATCH] simple-diagnostic-path: Inline two trivial methods [PR116143]

2025-02-26 Thread Richard Biener
On Wed, Feb 26, 2025 at 3:01 PM Jakub Jelinek wrote: > > On Wed, Feb 26, 2025 at 07:55:28AM -0500, David Malcolm wrote: > > BTW, Qing Zhao's patch kit > > "[PATCH v4 0/3][RFC]Provide more contexts for -Warray-bounds and - > > Wstringop-* warning messages" > > https://gcc.gnu.org/pipermail/gcc-pa

Re: [PATCH] simple-diagnostic-path: Inline two trivial methods [PR116143]

2025-02-26 Thread Jakub Jelinek
On Wed, Feb 26, 2025 at 07:55:28AM -0500, David Malcolm wrote: > BTW, Qing Zhao's patch kit > "[PATCH v4 0/3][RFC]Provide more contexts for -Warray-bounds and - > Wstringop-* warning messages" > https://gcc.gnu.org/pipermail/gcc-patches/2025-January/673474.html I'm not sure we want that, that is

Re: [PATCH] simple-diagnostic-path: Inline two trivial methods [PR116143]

2025-02-26 Thread David Malcolm
On Wed, 2025-02-26 at 09:44 +0100, Jakub Jelinek wrote: > Hi! > > Various plugin tests fail with --enable-checking=release, because the > num_events and num_threads methods of simple_diagnostic_path are only > used > inside of #if CHECKING_P code inside of GCC proper and then tested > inside of >

Re: [PATCH] simple-diagnostic-path: Inline two trivial methods [PR116143]

2025-02-26 Thread Richard Biener
On Wed, Feb 26, 2025 at 10:27 AM Jakub Jelinek wrote: > > Hi! > > Various plugin tests fail with --enable-checking=release, because the > num_events and num_threads methods of simple_diagnostic_path are only used > inside of #if CHECKING_P code inside of GCC proper and then tested inside of > some

[PATCH] simple-diagnostic-path: Inline two trivial methods [PR116143]

2025-02-26 Thread Jakub Jelinek
Hi! Various plugin tests fail with --enable-checking=release, because the num_events and num_threads methods of simple_diagnostic_path are only used inside of #if CHECKING_P code inside of GCC proper and then tested inside of some plugin tests. So, with --enable-checking=yes they are compiled int