Re: [PATCH] selftest: remove "Yoda ordering" in assertions

2018-04-30 Thread Jeff Law
On 04/30/2018 09:48 AM, David Malcolm wrote: > Our selftest assertions were of the form: > > ASSERT_EQ (expected, actual) > > and both Richard Sandiford and I find this "Yoda ordering" confusing. > > Our existing tests aren't entirely consistent about this, and it doesn't make > sense for ASSE

[PATCH] selftest: remove "Yoda ordering" in assertions

2018-04-30 Thread David Malcolm
Our selftest assertions were of the form: ASSERT_EQ (expected, actual) and both Richard Sandiford and I find this "Yoda ordering" confusing. Our existing tests aren't entirely consistent about this, and it doesn't make sense for ASSERT_NE and its variants. The ordering comes from googletest's