Re: PING^3: Re: [PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-11-26 Thread Mike Stump
On Nov 26, 2024, at 11:55 AM, David Malcolm wrote: > > Ping Ok. I'll punt on the diff documentation bits. > On Mon, 2024-11-18 at 16:22 -0500, David Malcolm wrote: >> Another ping for this patch; any pex experts out there? >> >> Thanks! >> Dave >> >> On Wed, 2024-05-29 at 17:06 -0400, David M

PING^3: Re: [PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-11-26 Thread David Malcolm
Ping On Mon, 2024-11-18 at 16:22 -0500, David Malcolm wrote: > Another ping for this patch; any pex experts out there? > > Thanks! > Dave > > On Wed, 2024-05-29 at 17:06 -0400, David Malcolm wrote: > > On Wed, 2024-05-29 at 16:35 -0400, Eric Gallager wrote: > > > On Tue, May 28, 2024 at 1:21 PM

PING^2: Re: [PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-11-18 Thread David Malcolm
Another ping for this patch; any pex experts out there? Thanks! Dave On Wed, 2024-05-29 at 17:06 -0400, David Malcolm wrote: > On Wed, 2024-05-29 at 16:35 -0400, Eric Gallager wrote: > > On Tue, May 28, 2024 at 1:21 PM David Malcolm > > wrote: > > > > > > Ping. > > > > > > This patch has actua

Re: PING: Re: [PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-06-26 Thread Eric Gallager
On Wed, May 29, 2024 at 5:06 PM David Malcolm wrote: > > On Wed, 2024-05-29 at 16:35 -0400, Eric Gallager wrote: > > On Tue, May 28, 2024 at 1:21 PM David Malcolm > > wrote: > > > > > > Ping. > > > > > > This patch has actually been *very* helpful to me when debugging > > > selftest failures invo

Re: PING: Re: [PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-05-29 Thread David Malcolm
On Wed, 2024-05-29 at 16:35 -0400, Eric Gallager wrote: > On Tue, May 28, 2024 at 1:21 PM David Malcolm > wrote: > > > > Ping. > > > > This patch has actually been *very* helpful to me when debugging > > selftest failures involving ASSERT_STREQ. > > > > Thanks > > Dave > > > > Currently `diff

Re: PING: Re: [PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-05-29 Thread Eric Gallager
On Tue, May 28, 2024 at 1:21 PM David Malcolm wrote: > > Ping. > > This patch has actually been *very* helpful to me when debugging > selftest failures involving ASSERT_STREQ. > > Thanks > Dave > Currently `diff` is only listed under the "Tools/packages necessary for modifying GCC" section of ins

PING: Re: [PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-05-28 Thread David Malcolm
Ping. This patch has actually been *very* helpful to me when debugging selftest failures involving ASSERT_STREQ. Thanks Dave On Fri, 2024-05-17 at 15:51 -0400, David Malcolm wrote: > Currently when ASSERT_STREQ or ASSERT_STREQ_AT fail we print > both strings to stderr.  However it can be hard to

[PATCH] selftest: invoke "diff" when ASSERT_STREQ fails

2024-05-17 Thread David Malcolm
Currently when ASSERT_STREQ or ASSERT_STREQ_AT fail we print both strings to stderr. However it can be hard to figure out the problem (e.g. for 1-character differences in long strings). Extend the output by writing out the strings to tempfiles and invoking "diff -up" on them when we have such a s