Re: [PATCH] sanopt: Avoid crash on anonymous parameter [PR93436]

2020-01-27 Thread Martin Liška
On 1/26/20 10:18 PM, Marek Polacek wrote: Sure, that's better, thanks. Thank you for the fix Marek. Martin

Re: [PATCH] sanopt: Avoid crash on anonymous parameter [PR93436]

2020-01-26 Thread Jakub Jelinek
On Sun, Jan 26, 2020 at 04:18:33PM -0500, Marek Polacek wrote: > 2020-01-26 Marek Polacek > > PR tree-optimization/93436 > * sanopt.c (sanitize_rewrite_addressable_params): Avoid crash on > null DECL_NAME. LGTM, thanks. > --- > gcc/sanopt.c | 9 ++--- > 1 file changed,

Re: [PATCH] sanopt: Avoid crash on anonymous parameter [PR93436]

2020-01-26 Thread Marek Polacek
On Sun, Jan 26, 2020 at 12:09:09PM +0100, Jakub Jelinek wrote: > On Sat, Jan 25, 2020 at 07:13:20PM -0500, Marek Polacek wrote: > > Here we crash when using -fsanitize=address -fdump-tree-sanopt because > > the dumping code uses IDENTIFIER_POINTER on a null DECL_NAME. Instead, > > we can print ""

Re: [PATCH] sanopt: Avoid crash on anonymous parameter [PR93436]

2020-01-26 Thread Jakub Jelinek
On Sat, Jan 25, 2020 at 07:13:20PM -0500, Marek Polacek wrote: > Here we crash when using -fsanitize=address -fdump-tree-sanopt because > the dumping code uses IDENTIFIER_POINTER on a null DECL_NAME. Instead, > we can print "" in such a case. Or we could avoid printing > that diagnostic altogethe

[PATCH] sanopt: Avoid crash on anonymous parameter [PR93436]

2020-01-25 Thread Marek Polacek
Here we crash when using -fsanitize=address -fdump-tree-sanopt because the dumping code uses IDENTIFIER_POINTER on a null DECL_NAME. Instead, we can print "" in such a case. Or we could avoid printing that diagnostic altogether. I don't think this warrants a testcase. Tested x86_64-linux, ok fo