Re: [PATCH] rtl-ssa: Fix thinko when adding live-out uses

2025-08-20 Thread Richard Sandiford
Richard Biener writes: > On Wed, Aug 20, 2025 at 1:03 PM Richard Sandiford > wrote: >> >> While testing a later patch, I found that create_degenerate_phi >> had an inverted test for bitmap_set_bit. It was assuming that >> the return value was the previous bit value, rather than a >> "something c

Re: [PATCH] rtl-ssa: Fix thinko when adding live-out uses

2025-08-20 Thread Richard Biener
On Wed, Aug 20, 2025 at 2:16 PM Richard Sandiford wrote: > > Richard Biener writes: > > On Wed, Aug 20, 2025 at 1:03 PM Richard Sandiford > > wrote: > >> > >> While testing a later patch, I found that create_degenerate_phi > >> had an inverted test for bitmap_set_bit. It was assuming that > >>

Re: [PATCH] rtl-ssa: Fix thinko when adding live-out uses

2025-08-20 Thread Richard Biener
On Wed, Aug 20, 2025 at 1:03 PM Richard Sandiford wrote: > > While testing a later patch, I found that create_degenerate_phi > had an inverted test for bitmap_set_bit. It was assuming that > the return value was the previous bit value, rather than a > "something changed" value. :( > > Also, the c

[PATCH] rtl-ssa: Fix thinko when adding live-out uses

2025-08-20 Thread Richard Sandiford
While testing a later patch, I found that create_degenerate_phi had an inverted test for bitmap_set_bit. It was assuming that the return value was the previous bit value, rather than a "something changed" value. :( Also, the call to add_live_out_use shouldn't be conditional on the DF_LR_OUT opera