Re: [PATCH] rtl-optimization/120182 - wrong-code with RTL DSE and constant addresses

2025-05-09 Thread Jakub Jelinek
On Fri, May 09, 2025 at 09:17:23AM +0200, Richard Biener wrote: > RTL DSE forms store groups from unique invariant bases but that is > confused when presented with constant addresses where it assigns > one store group per unique address. That causes it to not consider > 0x101:QI to alias 0x100:SI.

Re: [PATCH] rtl-optimization/120182 - wrong-code with RTL DSE and constant addresses

2025-05-09 Thread Jakub Jelinek
On Fri, May 09, 2025 at 11:01:58AM +0200, Richard Biener wrote: > On Fri, 9 May 2025, Jakub Jelinek wrote: > > > On Fri, May 09, 2025 at 09:34:14AM +0200, Richard Biener wrote: > > > > Perhaps better CONST_SCALAR_INT_P instead of CONST_INT_P? > > > > > > Do we ever get a wide_int for Pmode/ptr_mo

Re: [PATCH] rtl-optimization/120182 - wrong-code with RTL DSE and constant addresses

2025-05-09 Thread Richard Biener
On Fri, 9 May 2025, Jakub Jelinek wrote: > On Fri, May 09, 2025 at 11:01:58AM +0200, Richard Biener wrote: > > On Fri, 9 May 2025, Jakub Jelinek wrote: > > > > > On Fri, May 09, 2025 at 09:34:14AM +0200, Richard Biener wrote: > > > > > Perhaps better CONST_SCALAR_INT_P instead of CONST_INT_P? > >

Re: [PATCH] rtl-optimization/120182 - wrong-code with RTL DSE and constant addresses

2025-05-09 Thread Richard Biener
On Fri, 9 May 2025, Jakub Jelinek wrote: > On Fri, May 09, 2025 at 09:34:14AM +0200, Richard Biener wrote: > > > Perhaps better CONST_SCALAR_INT_P instead of CONST_INT_P? > > > > Do we ever get a wide_int for Pmode/ptr_mode? But sure, I can > > Most likely not. Only if we start supporting > 64

Re: [PATCH] rtl-optimization/120182 - wrong-code with RTL DSE and constant addresses

2025-05-09 Thread Jakub Jelinek
On Fri, May 09, 2025 at 09:34:14AM +0200, Richard Biener wrote: > > Perhaps better CONST_SCALAR_INT_P instead of CONST_INT_P? > > Do we ever get a wide_int for Pmode/ptr_mode? But sure, I can Most likely not. Only if we start supporting > 64-bit pointers. Jakub

Re: [PATCH] rtl-optimization/120182 - wrong-code with RTL DSE and constant addresses

2025-05-09 Thread Richard Biener
On Fri, 9 May 2025, Jakub Jelinek wrote: > On Fri, May 09, 2025 at 09:17:23AM +0200, Richard Biener wrote: > > RTL DSE forms store groups from unique invariant bases but that is > > confused when presented with constant addresses where it assigns > > one store group per unique address. That cause

[PATCH] rtl-optimization/120182 - wrong-code with RTL DSE and constant addresses

2025-05-09 Thread Richard Biener
RTL DSE forms store groups from unique invariant bases but that is confused when presented with constant addresses where it assigns one store group per unique address. That causes it to not consider 0x101:QI to alias 0x100:SI. Constant accesses can really alias to every object, in practice they a