Re: [PATCH] rtl: Join the insn and split conditions in define_insn_and_split

2021-06-08 Thread Richard Sandiford via Gcc-patches
Segher Boessenkool writes: > On Tue, Jun 08, 2021 at 04:50:56PM +0100, Richard Sandiford wrote: >> Segher Boessenkool writes: >> > On Tue, Jun 08, 2021 at 02:48:11PM +0200, Richard Biener wrote: >> >> > So yeah, patch withdrawn. This on one hand is proof we do want to make >> >> > such a change,

Re: [PATCH] rtl: Join the insn and split conditions in define_insn_and_split

2021-06-08 Thread Segher Boessenkool
On Tue, Jun 08, 2021 at 04:50:56PM +0100, Richard Sandiford wrote: > Segher Boessenkool writes: > > On Tue, Jun 08, 2021 at 02:48:11PM +0200, Richard Biener wrote: > >> > So yeah, patch withdrawn. This on one hand is proof we do want to make > >> > such a change, but on the other hand shows it ne

Re: [PATCH] rtl: Join the insn and split conditions in define_insn_and_split

2021-06-08 Thread Richard Sandiford via Gcc-patches
Segher Boessenkool writes: > On Tue, Jun 08, 2021 at 02:48:11PM +0200, Richard Biener wrote: >> > So yeah, patch withdrawn. This on one hand is proof we do want to make >> > such a change, but on the other hand shows it needs more preparatory >> > steps. >> >> I wonder if it makes sense to provi

Re: [PATCH] rtl: Join the insn and split conditions in define_insn_and_split

2021-06-08 Thread Segher Boessenkool
On Tue, Jun 08, 2021 at 02:48:11PM +0200, Richard Biener wrote: > > So yeah, patch withdrawn. This on one hand is proof we do want to make > > such a change, but on the other hand shows it needs more preparatory > > steps. > > I wonder if it makes sense to provide ports a means to opt-in into > t

Re: [PATCH] rtl: Join the insn and split conditions in define_insn_and_split

2021-06-08 Thread Richard Biener via Gcc-patches
On Tue, Jun 8, 2021 at 2:27 PM Segher Boessenkool wrote: > > On Tue, Jun 08, 2021 at 09:05:57AM +0200, Richard Biener wrote: > > On Tue, Jun 8, 2021 at 12:05 AM Segher Boessenkool > > wrote: > > > > > > In theory we could have a split condition not inclusive of the insn > > > condition in the pas

Re: [PATCH] rtl: Join the insn and split conditions in define_insn_and_split

2021-06-08 Thread Segher Boessenkool
On Tue, Jun 08, 2021 at 09:05:57AM +0200, Richard Biener wrote: > On Tue, Jun 8, 2021 at 12:05 AM Segher Boessenkool > wrote: > > > > In theory we could have a split condition not inclusive of the insn > > condition in the past. That never was a good idea, the code does not do > > what a non-susp

Re: [PATCH] rtl: Join the insn and split conditions in define_insn_and_split

2021-06-08 Thread Richard Biener via Gcc-patches
On Tue, Jun 8, 2021 at 12:05 AM Segher Boessenkool wrote: > > In theory we could have a split condition not inclusive of the insn > condition in the past. That never was a good idea, the code does not do > what a non-suspicious reader would think it does. But it leads to more > serious problems

[PATCH] rtl: Join the insn and split conditions in define_insn_and_split

2021-06-07 Thread Segher Boessenkool
In theory we could have a split condition not inclusive of the insn condition in the past. That never was a good idea, the code does not do what a non-suspicious reader would think it does. But it leads to more serious problems together with iterators: if the split condition (as written) does not