Re: [PATCH] rs6000: Fix vector parity support [PR108699]

Hi Segher, Thanks for the comments! on 2023/2/19 20:12, Segher Boessenkool wrote: > Hi! > > On Fri, Feb 17, 2023 at 11:33:16AM +0800, Kewen.Lin wrote: >> on 2023/2/16 23:10, Segher Boessenkool wrote: >>> No, you are right that the semantics are pretty much the same. Please >>> just keep UNSPEC_

Re: [PATCH] rs6000: Fix vector parity support [PR108699]

Hi! On Fri, Feb 17, 2023 at 11:33:16AM +0800, Kewen.Lin wrote: > on 2023/2/16 23:10, Segher Boessenkool wrote: > > No, you are right that the semantics are pretty much the same. Please > > just keep UNSPEC_PARITY everywhere. > > OK, since it has UNSPEC, I would hope the reader can realize it's >

Re: [PATCH] rs6000: Fix vector parity support [PR108699]

Hi Segher, Thanks for the comments! on 2023/2/16 23:10, Segher Boessenkool wrote: > Hi! > > On Thu, Feb 16, 2023 at 08:06:02PM +0800, Kewen.Lin wrote: >> on 2023/2/16 19:14, Segher Boessenkool wrote: >>> On Thu, Feb 16, 2023 at 05:23:40PM +0800, Kewen.Lin wrote: This patch is to fix the han

Re: [PATCH] rs6000: Fix vector parity support [PR108699]

Hi! On Thu, Feb 16, 2023 at 08:06:02PM +0800, Kewen.Lin wrote: > on 2023/2/16 19:14, Segher Boessenkool wrote: > > On Thu, Feb 16, 2023 at 05:23:40PM +0800, Kewen.Lin wrote: > >> This patch is to fix the handling with one more pre-insn > >> vpopcntb. It also fixes an oversight having V8HI in VEC_

Re: [PATCH] rs6000: Fix vector parity support [PR108699]

Hi Segher, Thanks for the review comments! on 2023/2/16 19:14, Segher Boessenkool wrote: > Hi! > > On Thu, Feb 16, 2023 at 05:23:40PM +0800, Kewen.Lin wrote: >> This patch is to fix the handling with one more pre-insn >> vpopcntb. It also fixes an oversight having V8HI in VEC_IP, >> replaces VP

Re: [PATCH] rs6000: Fix vector parity support [PR108699]

Hi! On Thu, Feb 16, 2023 at 05:23:40PM +0800, Kewen.Lin wrote: > This patch is to fix the handling with one more pre-insn > vpopcntb. It also fixes an oversight having V8HI in VEC_IP, > replaces VParity with VEC_IP, and adjusts the existing > UNSPEC_PARITY to a more meaningful name UNSPEC_PARITYB

[PATCH] rs6000: Fix vector parity support [PR108699]

Hi, The failures on the original failed case builtin-bitops-1.c and the associated test case pr108699.c here show that the current support of parity vector mode is wrong on Power. The hardware insns vprtyb[wdq] which operate on the least significant bit of each byte per element, they doesn't match