Re: [PATCH] rs6000: Fix infinite loop building ghostscript and icu [PR93658]

2020-02-23 Thread Peter Bergner
On 2/22/20 6:49 PM, Segher Boessenkool wrote: > On Sat, Feb 22, 2020 at 06:25:43PM -0600, Peter Bergner wrote: >> Is this still ok for GCC 8 & 9? > > Please do each of those backports as separate commits (so that if there > is a problem with them, we can bisect it; it also should be easier to do >

Re: [PATCH] rs6000: Fix infinite loop building ghostscript and icu [PR93658]

2020-02-22 Thread Segher Boessenkool
On Sat, Feb 22, 2020 at 06:25:43PM -0600, Peter Bergner wrote: > On 2/20/20 11:33 AM, Peter Bergner wrote: > > Ok, I pushed the trunk fix now. I'll kick off the release branch > > backports now. > > > > Jakub, I know you're getting the GCC 8.4 release ready. Is this fix ok > > for FSF 8 now or d

Re: [PATCH] rs6000: Fix infinite loop building ghostscript and icu [PR93658]

2020-02-22 Thread Peter Bergner
On 2/20/20 11:33 AM, Peter Bergner wrote: > Ok, I pushed the trunk fix now. I'll kick off the release branch > backports now. > > Jakub, I know you're getting the GCC 8.4 release ready. Is this fix ok > for FSF 8 now or do you want me to wait until after 8.4 is out? The backport of the PR93658

Re: [PATCH] rs6000: Fix infinite loop building ghostscript and icu [PR93658]

2020-02-21 Thread Richard Biener
On Thu, Feb 20, 2020 at 6:33 PM Peter Bergner wrote: > > On 2/20/20 1:47 AM, Segher Boessenkool wrote: > > On Wed, Feb 19, 2020 at 09:17:26PM -0600, Peter Bergner wrote: > >> This passed bootstrap and regtesting on powerpc64le-linux and > >> powerpc64-linux > >> (in both 32-bit and 64-bit modes)

Re: [PATCH] rs6000: Fix infinite loop building ghostscript and icu [PR93658]

2020-02-20 Thread Peter Bergner
On 2/20/20 1:47 AM, Segher Boessenkool wrote: > On Wed, Feb 19, 2020 at 09:17:26PM -0600, Peter Bergner wrote: >> This passed bootstrap and regtesting on powerpc64le-linux and powerpc64-linux >> (in both 32-bit and 64-bit modes) with no regressions. Ok for trunk? >> The same bug exists in FSF 9 an

Re: [PATCH] rs6000: Fix infinite loop building ghostscript and icu [PR93658]

2020-02-19 Thread Segher Boessenkool
On Wed, Feb 19, 2020 at 09:17:26PM -0600, Peter Bergner wrote: > PR93658 shows a problem in rs6000_legitimate_address_p() where we erroneously > mark an Altivec address as being invalid, which causes LRA to go into an > infinite loop spilling the same address over and over again. The problem > is,

[PATCH] rs6000: Fix infinite loop building ghostscript and icu [PR93658]

2020-02-19 Thread Peter Bergner
PR93658 shows a problem in rs6000_legitimate_address_p() where we erroneously mark an Altivec address as being invalid, which causes LRA to go into an infinite loop spilling the same address over and over again. The problem is, when VSX is enabled, the rs6000_vector_mem[], returns VECTOR_VSX rathe