Re: [PATCH] rs6000: Don't ICE when spilling an MMA accumulator

2020-08-08 Thread Peter Bergner via Gcc-patches
On 8/6/20 10:29 AM, Peter Bergner wrote: > On 8/5/20 6:06 PM, Segher Boessenkool wrote: > Ok, updated patch pushed to trunk. I'll push to GCC10 after a day or two. And now pushed to GCC 10. Peter

Re: [PATCH] rs6000: Don't ICE when spilling an MMA accumulator

2020-08-06 Thread Peter Bergner via Gcc-patches
On 8/5/20 6:06 PM, Segher Boessenkool wrote: > You can just say > >&& reload_completed >&& !(fpr_reg_operand (operands[0], PXImode) && operands[1] == const0_rtx) > > afaics? Agreed. I made that change and retested which was clean. > Okay (for trunk, and later 10) with or without such

Re: [PATCH] rs6000: Don't ICE when spilling an MMA accumulator

2020-08-05 Thread Segher Boessenkool
Hi! On Wed, Aug 05, 2020 at 02:02:36PM -0500, Peter Bergner wrote: > The following patch fixes one of the bugs discovered in PR96466, namely > when we spill an accumulator that has a known zero value. In that case, > LRA would emit a new (set (reg:PXI ...) 0) insn, but it would not use the > mma_

Re: [PATCH] rs6000: Don't ICE when spilling an MMA accumulator

2020-08-05 Thread Peter Bergner via Gcc-patches
On 8/5/20 2:02 PM, Peter Bergner wrote: > This patch fixes the ICE and is in the middle of regression testing. > Ok for trunk if the testing comes back clean? Testing was clean with no regressions. Peter

[PATCH] rs6000: Don't ICE when spilling an MMA accumulator

2020-08-05 Thread Peter Bergner via Gcc-patches
The following patch fixes one of the bugs discovered in PR96466, namely when we spill an accumulator that has a known zero value. In that case, LRA would emit a new (set (reg:PXI ...) 0) insn, but it would not use the mma_xxsetaccz pattern to do it. The solution is to move the xxsetaccz instructi