Re: [PATCH] rs6000: Disable -fcaller-saves by default

2020-08-26 Thread Jeff Law via Gcc-patches
On Wed, 2020-08-26 at 15:58 -0500, Segher Boessenkool wrote: > On Tue, Aug 25, 2020 at 02:35:51PM -0600, Jeff Law wrote: > > I've gone back and forth on pre allocation splitting as well as > > post-allocating > > splitting and re-allocation. I could argue either side of that discussion > > -- >

Re: [PATCH] rs6000: Disable -fcaller-saves by default

2020-08-26 Thread Segher Boessenkool
On Tue, Aug 25, 2020 at 02:35:51PM -0600, Jeff Law wrote: > I've gone back and forth on pre allocation splitting as well as > post-allocating > splitting and re-allocation. I could argue either side of that discussion -- If you end up wanting something split it is best to do it early. But if y

Re: [PATCH] rs6000: Disable -fcaller-saves by default

2020-08-25 Thread Jeff Law via Gcc-patches
On Mon, 2020-08-10 at 11:11 -0500, Peter Bergner wrote: > On 7/23/20 3:29 PM, Jeff Law wrote: > > > > What's driving this change? > > > > > > Peter noticed IRA allocates stuff to volatile registers while it is life > > > through a call, and then LRA has to correct that, not optimal. > > I can't re

Re: [PATCH] rs6000: Disable -fcaller-saves by default

2020-08-10 Thread Peter Bergner via Gcc-patches
On 7/23/20 3:29 PM, Jeff Law wrote: >>> What's driving this change? >> >> Peter noticed IRA allocates stuff to volatile registers while it is life >> through a call, and then LRA has to correct that, not optimal. > I can't recall if IRA or LRA handles the need to save them to the stack, but > the

Re: [PATCH] rs6000: Disable -fcaller-saves by default

2020-07-23 Thread Segher Boessenkool
On Thu, Jul 23, 2020 at 02:29:00PM -0600, Jeff Law wrote: > On Thu, 2020-07-23 at 15:19 -0500, Segher Boessenkool wrote: > > On Thu, Jul 23, 2020 at 01:42:59PM -0600, Jeff Law wrote: > > > On Thu, 2020-07-23 at 14:25 -0500, Pat Haugen via Gcc-patches wrote: > > > > Disable -fcaller-saves by default

Re: [PATCH] rs6000: Disable -fcaller-saves by default

2020-07-23 Thread Jeff Law via Gcc-patches
On Thu, 2020-07-23 at 15:19 -0500, Segher Boessenkool wrote: > Hi! > > On Thu, Jul 23, 2020 at 01:42:59PM -0600, Jeff Law wrote: > > On Thu, 2020-07-23 at 14:25 -0500, Pat Haugen via Gcc-patches wrote: > > > Disable -fcaller-saves by default. > > > > > > This patch turns off -fcaller-saves by def

Re: [PATCH] rs6000: Disable -fcaller-saves by default

2020-07-23 Thread Segher Boessenkool
Hi! On Thu, Jul 23, 2020 at 01:42:59PM -0600, Jeff Law wrote: > On Thu, 2020-07-23 at 14:25 -0500, Pat Haugen via Gcc-patches wrote: > > Disable -fcaller-saves by default. > > > > This patch turns off -fcaller-saves by default so that IRA doesn't try > > to use volatile regs for pseudos that are

Re: [PATCH] rs6000: Disable -fcaller-saves by default

2020-07-23 Thread Jeff Law via Gcc-patches
On Thu, 2020-07-23 at 14:25 -0500, Pat Haugen via Gcc-patches wrote: > Disable -fcaller-saves by default. > > This patch turns off -fcaller-saves by default so that IRA doesn't try > to use volatile regs for pseudos that are live across a call, which > would then require LRA to save/restore the re

[PATCH] rs6000: Disable -fcaller-saves by default

2020-07-23 Thread Pat Haugen via Gcc-patches
Disable -fcaller-saves by default. This patch turns off -fcaller-saves by default so that IRA doesn't try to use volatile regs for pseudos that are live across a call, which would then require LRA to save/restore the reg around the call. Bootstrap/regtest on powerpc64le with no new regressions. A