Re: [PATCH] riscv: Allocate enough space to strcpy() string

2024-06-15 Thread Kito Cheng
Ok for gcc 14 too :) Christoph Müllner 於 2024年6月15日 週六 15:14 寫道: > > > On Sat, Jun 15, 2024, 08:25 Kito Cheng wrote: > >> Oooops, thanks for catching that! It's LGTM:) >> > > Also OK for the GCC 14 branch? > > >> Christoph Müllner 於 2024年6月15日 週六 04:58 寫道: >> >>> I triggered an ICE on Ubuntu 2

Re: [PATCH] riscv: Allocate enough space to strcpy() string

2024-06-15 Thread Christoph Müllner
On Sat, Jun 15, 2024, 08:25 Kito Cheng wrote: > Oooops, thanks for catching that! It's LGTM:) > Also OK for the GCC 14 branch? > Christoph Müllner 於 2024年6月15日 週六 04:58 寫道: > >> I triggered an ICE on Ubuntu 24.04 when compiling code that uses >> function attributes. Looking into the sources s

Re: [PATCH] riscv: Allocate enough space to strcpy() string

2024-06-14 Thread Kito Cheng
Oooops, thanks for catching that! It's LGTM:) Christoph Müllner 於 2024年6月15日 週六 04:58 寫道: > I triggered an ICE on Ubuntu 24.04 when compiling code that uses > function attributes. Looking into the sources shows that we have > a systematic issue in the attribute handling code: > * we determine th

[PATCH] riscv: Allocate enough space to strcpy() string

2024-06-14 Thread Christoph Müllner
I triggered an ICE on Ubuntu 24.04 when compiling code that uses function attributes. Looking into the sources shows that we have a systematic issue in the attribute handling code: * we determine the length with strlen() (excluding the terminating null) * we allocate a buffer with this length * we