Re: [PATCH] restore CFString handling in attribute format (PR 88638)

2019-01-14 Thread Martin Sebor
On 1/5/19 2:41 PM, Dominique d'Humières wrote: Hi Martin, The patch on top of r267591 fixes pr88638 without regression. Note FAIL: c-c++-common/attributes-4.c -std=gnu++14 (test for excess errors) FAIL: c-c++-common/attributes-4.c -std=gnu++17 (test for excess errors) FAIL: c-c++-commo

Re: [PATCH] restore CFString handling in attribute format (PR 88638)

2019-01-11 Thread Jeff Law
On 1/6/19 4:34 PM, Martin Sebor wrote: > Attached is an updated patch with the wording change to the manual > discussed below and rebased on the top of today's trunk. > > Martin > > PS Thanks for the additional info, Iain. > > On 1/5/19 10:53 AM, Iain Sandoe wrote: >> >>> On 5 Jan 2019, at 17:39

Re: [PATCH] restore CFString handling in attribute format (PR 88638)

2019-01-07 Thread Iain Sandoe
> On 6 Jan 2019, at 23:34, Martin Sebor wrote: > > Attached is an updated patch with the wording change to the manual > discussed below and rebased on the top of today's trunk. Works for me as well. thanks for the patch. Iain > > Martin > > PS Thanks for the additional info, Iain. > > On

Re: [PATCH] restore CFString handling in attribute format (PR 88638)

2019-01-06 Thread Martin Sebor
Attached is an updated patch with the wording change to the manual discussed below and rebased on the top of today's trunk. Martin PS Thanks for the additional info, Iain. On 1/5/19 10:53 AM, Iain Sandoe wrote: On 5 Jan 2019, at 17:39, Martin Sebor wrote: On 1/5/19 3:31 AM, Iain Sandoe wro

Re: [PATCH] restore CFString handling in attribute format (PR 88638)

2019-01-05 Thread Dominique d'Humières
Hi Martin, The patch on top of r267591 fixes pr88638 without regression. Note FAIL: c-c++-common/attributes-4.c -std=gnu++14 (test for excess errors) FAIL: c-c++-common/attributes-4.c -std=gnu++17 (test for excess errors) FAIL: c-c++-common/attributes-4.c -std=gnu++98 (test for excess erro

Re: [PATCH] restore CFString handling in attribute format (PR 88638)

2019-01-05 Thread Iain Sandoe
> On 5 Jan 2019, at 17:39, Martin Sebor wrote: > > On 1/5/19 3:31 AM, Iain Sandoe wrote: >> Hi Martin, >>> On 4 Jan 2019, at 22:30, Mike Stump wrote: >>> >>> On Jan 4, 2019, at 2:03 PM, Martin Sebor wrote: The improved handling of attribute positional arguments added in r2661

Re: [PATCH] restore CFString handling in attribute format (PR 88638)

2019-01-05 Thread Martin Sebor
On 1/5/19 3:31 AM, Iain Sandoe wrote: Hi Martin, On 4 Jan 2019, at 22:30, Mike Stump wrote: On Jan 4, 2019, at 2:03 PM, Martin Sebor wrote: The improved handling of attribute positional arguments added in r266195 introduced a regression on Darwin where attribute format with the CFString ar

Re: [PATCH] restore CFString handling in attribute format (PR 88638)

2019-01-05 Thread Iain Sandoe
Hi Martin, > On 4 Jan 2019, at 22:30, Mike Stump wrote: > > On Jan 4, 2019, at 2:03 PM, Martin Sebor wrote: >> >> The improved handling of attribute positional arguments added >> in r266195 introduced a regression on Darwin where attribute >> format with the CFString archetype accepts CFString

Re: [PATCH] restore CFString handling in attribute format (PR 88638)

2019-01-04 Thread Mike Stump
On Jan 4, 2019, at 2:03 PM, Martin Sebor wrote: > > The improved handling of attribute positional arguments added > in r266195 introduced a regression on Darwin where attribute > format with the CFString archetype accepts CFString* parameter > types in positions where only char* would otherwise b

[PATCH] restore CFString handling in attribute format (PR 88638)

2019-01-04 Thread Martin Sebor
The improved handling of attribute positional arguments added in r266195 introduced a regression on Darwin where attribute format with the CFString archetype accepts CFString* parameter types in positions where only char* would otherwise be allowed. This is specific to Darwin so it didn't show up