Re: [PATCH] print-rtl: Fix printing of CONST_STRING in DEBUG_INSNs [PR93399]

2020-03-05 Thread Richard Biener
On Thu, 5 Mar 2020, Jakub Jelinek wrote: > On Thu, Mar 05, 2020 at 08:55:33AM +0100, Richard Biener wrote: > > It looks like tree-pretty-print.c doesn't bother to truncate it > > so why bother for RTL? > > Ok, so I'll go then with the size_t argument, so that nothing needs to be > truncated. > Up

Re: [PATCH] print-rtl: Fix printing of CONST_STRING in DEBUG_INSNs [PR93399]

2020-03-05 Thread Jakub Jelinek
On Thu, Mar 05, 2020 at 08:55:33AM +0100, Richard Biener wrote: > It looks like tree-pretty-print.c doesn't bother to truncate it > so why bother for RTL? Ok, so I'll go then with the size_t argument, so that nothing needs to be truncated. Updated patch: 2020-03-05 Jakub Jelinek PR mi

Re: [PATCH] print-rtl: Fix printing of CONST_STRING in DEBUG_INSNs [PR93399]

2020-03-04 Thread Richard Biener
On Thu, 5 Mar 2020, Jakub Jelinek wrote: > Hi! > > The following testcase fails to assemble, as CONST_STRING in the DEBUG_INSNs > is printed as is, so if it contains \n and/or \r, we are in trouble: > .loc 1 14 3 > # DEBUG haystack => [si] > # DEBUG needle => " > " > In th

[PATCH] print-rtl: Fix printing of CONST_STRING in DEBUG_INSNs [PR93399]

2020-03-04 Thread Jakub Jelinek
Hi! The following testcase fails to assemble, as CONST_STRING in the DEBUG_INSNs is printed as is, so if it contains \n and/or \r, we are in trouble: .loc 1 14 3 # DEBUG haystack => [si] # DEBUG needle => " " In the gimple dumps we print those (STRING_CSTs) as # DEBUG hay