Re: [PATCH] powerpc: Fix ICE with fp conditional move (PR target/93073)

2020-01-22 Thread Iain Sandoe
Segher Boessenkool wrote: On Mon, Jan 20, 2020 at 11:52:55PM +0100, Jakub Jelinek wrote: PR target/93073 * config/rs6000/rs6000.c (rs6000_emit_cmove): Punt for compare_mode other than SFmode or DFmode. "If using fsel, punt for..." etc. + /* Don't allow compare_mode other th

Re: [PATCH] powerpc: Fix ICE with fp conditional move (PR target/93073)

2020-01-21 Thread Segher Boessenkool
Hi! On Mon, Jan 20, 2020 at 08:31:43PM -0500, Nicholas Krause wrote: > On 1/20/20 6:51 PM, Segher Boessenkool wrote: > >We can (and should) use other instructions than just fsel here as well > >(say, xscmpgedp followed by xxsel). This can also work for QP float, > >which also can be TFmode, just

Re: [PATCH] powerpc: Fix ICE with fp conditional move (PR target/93073)

2020-01-20 Thread Nicholas Krause
On 1/20/20 6:51 PM, Segher Boessenkool wrote: On Tue, Jan 21, 2020 at 12:23:02AM +0100, Jakub Jelinek wrote: On Mon, Jan 20, 2020 at 05:10:55PM -0600, Segher Boessenkool wrote: On Mon, Jan 20, 2020 at 11:52:55PM +0100, Jakub Jelinek wrote: PR target/93073 * config/rs6000/rs6

Re: [PATCH] powerpc: Fix ICE with fp conditional move (PR target/93073)

2020-01-20 Thread Segher Boessenkool
On Tue, Jan 21, 2020 at 12:23:02AM +0100, Jakub Jelinek wrote: > On Mon, Jan 20, 2020 at 05:10:55PM -0600, Segher Boessenkool wrote: > > On Mon, Jan 20, 2020 at 11:52:55PM +0100, Jakub Jelinek wrote: > > > PR target/93073 > > > * config/rs6000/rs6000.c (rs6000_emit_cmove): Punt for compare_mode

Re: [PATCH] powerpc: Fix ICE with fp conditional move (PR target/93073)

2020-01-20 Thread Jakub Jelinek
On Mon, Jan 20, 2020 at 05:10:55PM -0600, Segher Boessenkool wrote: > On Mon, Jan 20, 2020 at 11:52:55PM +0100, Jakub Jelinek wrote: > > PR target/93073 > > * config/rs6000/rs6000.c (rs6000_emit_cmove): Punt for compare_mode > > other than SFmode or DFmode. > > "If using fsel, punt for

Re: [PATCH] powerpc: Fix ICE with fp conditional move (PR target/93073)

2020-01-20 Thread Segher Boessenkool
Hi! On Mon, Jan 20, 2020 at 11:52:55PM +0100, Jakub Jelinek wrote: > PR target/93073 > * config/rs6000/rs6000.c (rs6000_emit_cmove): Punt for compare_mode > other than SFmode or DFmode. "If using fsel, punt for..." etc. > + /* Don't allow compare_mode other than SFmode or DFmo

[PATCH] powerpc: Fix ICE with fp conditional move (PR target/93073)

2020-01-20 Thread Jakub Jelinek
Hi! The following testcase ICEs, because for TFmode the particular subtraction pattern (*subtf3) is not enabled with the given options. Using expand_simple_binop instead of emitting the subtraction by hand just moves the ICE one insn later, NEG of ABS is not then recognized, etc., but ultimately