Re: [PATCH] phiopt: don't handle the case cond edge dest is itself [PR117243]

On Tue, Dec 3, 2024 at 12:34 AM Richard Biener wrote: > > On Mon, Dec 2, 2024 at 10:52 PM Andrew Pinski > wrote: > > > > After r12-5300-gf98f373dd822b3, phiopt could get the following bb structure: > > | > > middle-bb -| > > || > > | || | > > phi

Re: [PATCH] phiopt: don't handle the case cond edge dest is itself [PR117243]

On Mon, Dec 2, 2024 at 10:52 PM Andrew Pinski wrote: > > After r12-5300-gf98f373dd822b3, phiopt could get the following bb structure: > | > middle-bb -| > || > | || | > phi<1, 2> | | > cond | | > || | > |---

Re: [PATCH] phiopt: don't handle the case cond edge dest is itself [PR117243]

On Mon, Dec 2, 2024 at 2:05 PM Jakub Jelinek wrote: > > On Mon, Dec 02, 2024 at 01:51:39PM -0800, Andrew Pinski wrote: > > gcc/testsuite/ChangeLog: > > > > * gcc.dg/torture/pr117243-1.c: New test. > > * gcc.dg/torture/pr117243-2.c: New test. > > Just commenting on the testcases. > I do

Re: [PATCH] phiopt: don't handle the case cond edge dest is itself [PR117243]

On Mon, Dec 02, 2024 at 01:51:39PM -0800, Andrew Pinski wrote: > gcc/testsuite/ChangeLog: > > * gcc.dg/torture/pr117243-1.c: New test. > * gcc.dg/torture/pr117243-2.c: New test. Just commenting on the testcases. I don't like 2 tests times 7 different command line options each spend so

[PATCH] phiopt: don't handle the case cond edge dest is itself [PR117243]

After r12-5300-gf98f373dd822b3, phiopt could get the following bb structure: | middle-bb -| || | || | phi<1, 2> | | cond | | || | |+---| Which was considered 2 loops. The inner loop had esimtate of upper