Re: [PATCH] openmp: Retire nest-var ICV

2020-11-18 Thread Jakub Jelinek via Gcc-patches
On Wed, Nov 18, 2020 at 07:05:19PM +, Kwok Cheung Yeung wrote: > From a75481979c86aa1da5b5da641fc776bc71d156f7 Mon Sep 17 00:00:00 2001 > From: Kwok Cheung Yeung > Date: Wed, 18 Nov 2020 10:02:00 -0800 > Subject: [PATCH] openmp: Retire nest-var ICV for OpenMP 5.1 > > Thi

Re: [PATCH] openmp: Retire nest-var ICV

2020-11-18 Thread Kwok Cheung Yeung
00:00:00 2001 From: Kwok Cheung Yeung Date: Wed, 18 Nov 2020 10:02:00 -0800 Subject: [PATCH] openmp: Retire nest-var ICV for OpenMP 5.1 This removes the nest-var ICV, expressing nesting in terms of the max-active-levels-var ICV instead. The max-active-levels-var ICV is now per data e

Re: [PATCH] openmp: Retire nest-var ICV

2020-11-18 Thread Jakub Jelinek via Gcc-patches
On Thu, Nov 12, 2020 at 10:44:35PM +, Kwok Cheung Yeung wrote: > + /* OMP_NESTED is deprecated in OpenMP 5.0. */ > + if (parse_boolean ("OMP_NESTED", &nested)) > + gomp_global_icv.max_active_levels_var = > + nested ? gomp_supported_active_levels : 1; Formatting - = shoul

Re: [PATCH] openmp: Retire nest-var ICV

2020-11-12 Thread Kwok Cheung Yeung
On 10/11/2020 6:01 pm, Jakub Jelinek wrote: One thing is that max-active-levels-var in 5.0 is per-device, but in 5.1 per-data environment. The question is if we should implement the problematic 5.0 way or the 5.1 one. E.g.: #include #include int main () { #pragma omp parallel { om

Re: [PATCH] openmp: Retire nest-var ICV

2020-11-10 Thread Jakub Jelinek via Gcc-patches
On Mon, Nov 09, 2020 at 05:43:20PM +, Kwok Cheung Yeung wrote: > commit b4feb16f3c84b8f82163a4cbba6a31d55fbb8e5b > Author: Kwok Cheung Yeung > Date: Mon Nov 9 09:34:39 2020 -0800 > > openmp: Retire nest-var ICV for OpenMP 5.0 > > This removes the nest-var ICV, expressing nestin

Re: [PATCH] openmp: Retire nest-var ICV

2020-11-09 Thread Kwok Cheung Yeung
On 06/11/2020 8:33 pm, Tobias Burnus wrote: Hello Kwok, hi Jakub, On 06.11.20 21:13, Kwok Cheung Yeung wrote: In addition to deprecating the omp_(get|set)_nested() functions and OMP_NESTED environment variable, OpenMP 5.0 also removes the nest-var ICV altogether, defining it in terms of the m

Re: [PATCH] openmp: Retire nest-var ICV

2020-11-06 Thread Tobias Burnus
Hello Kwok, hi Jakub, On 06.11.20 21:13, Kwok Cheung Yeung wrote: In addition to deprecating the omp_(get|set)_nested() functions and OMP_NESTED environment variable, OpenMP 5.0 also removes the nest-var ICV altogether, defining it in terms of the max-active-levels-var ICV instead. [...] Shou

[PATCH] openmp: Retire nest-var ICV

2020-11-06 Thread Kwok Cheung Yeung
Hello In addition to deprecating the omp_(get|set)_nested() functions and OMP_NESTED environment variable, OpenMP 5.0 also removes the nest-var ICV altogether, defining it in terms of the max-active-levels-var ICV instead. This patch removes the ICV, and implements the handling of omp_(get|s