Re: [PATCH] openmp, fortran: Add support for declare variant in Fortran

2021-10-18 Thread Jakub Jelinek via Gcc-patches
On Mon, Oct 18, 2021 at 10:05:29PM +0100, Kwok Cheung Yeung wrote: > On 14/10/2021 1:47 pm, Jakub Jelinek wrote: > > What I still miss is tests for the (proc_name : variant_name) syntax > > in places where proc_name : is optional, but is supplied and is valid, like > > e.g. in interface, or in subr

Re: [PATCH] openmp, fortran: Add support for declare variant in Fortran

2021-10-18 Thread Kwok Cheung Yeung
On 14/10/2021 1:47 pm, Jakub Jelinek wrote: What I still miss is tests for the (proc_name : variant_name) syntax in places where proc_name : is optional, but is supplied and is valid, like e.g. in interface, or in subroutine/function and where proc_name specifies the name of the containing interf

Re: [PATCH] openmp, fortran: Add support for declare variant in Fortran

2021-10-14 Thread Jakub Jelinek via Gcc-patches
On Thu, Oct 14, 2021 at 11:04:59AM +0100, Kwok Cheung Yeung wrote: > I have now dropped this. This affects test2 in > gfortran.dg/gomp/declare-variant-8.f90, which I have added a comment to. Thanks. > I have added Fortran-specific tests as > gfortran.dg/gomp/declare-variant-15.f90 to declare-vari

Re: [PATCH] openmp, fortran: Add support for declare variant in Fortran

2021-10-06 Thread Jakub Jelinek via Gcc-patches
On Wed, Oct 06, 2021 at 12:39:01PM +0100, Kwok Cheung Yeung wrote: > --- a/gcc/gimplify.c > +++ b/gcc/gimplify.c > @@ -11599,8 +11599,11 @@ omp_construct_selector_matches (enum tree_code > *constructs, int nconstructs, > } > } >if (!target_seen > - && lookup_attribute ("omp dec

Re: [PATCH] openmp, fortran: Add support for declare variant in Fortran

2021-10-06 Thread Jakub Jelinek via Gcc-patches
On Wed, Oct 06, 2021 at 12:39:01PM +0100, Kwok Cheung Yeung wrote: > In secion 2.3.1 of the OpenMP 5.0 spec, it says: > > 3. For functions within a declare target block, the target trait is added to > the beginning of the set... > > But OpenMP in Fortran doesn't have the notion of a declare targe