[Patch, committed] OpenACC: Fix pattern in dg-bogus in Fortran testcases again (Re: [PATCH] openacc: Warnings for strange partitioning choices for parallel regions)

2021-04-26 Thread Tobias Burnus
Hi all, as discussed below/in this thread, the reset of the diagnostic contest affects the output with ENABLE_OFFLOAD. The attached patch now uses [Ww]arning in dg-bogus. It might be possible to reduce the differences between ENABLE_OFFLOAD being true or false, but it does not seem to be simple

Re: [PATCH] openacc: Warnings for strange partitioning choices for parallel regions

2021-04-26 Thread Tobias Burnus
On 26.04.21 21:54, Thomas Schwinge wrote: On 2021-04-26T14:32:10+0200, Tobias Burnus wrote: first, can you add an entry regarding this flag to https://gcc.gnu.org/gcc-12/changes.html ? Is that a standard thing that all new command-line flags do get highlighted there? (I wouldn't have consider

[Patch, committed] OpenACC: Fix pattern in dg-bogus in Fortran testcases (was: Re: [PATCH] openacc: Warnings for strange partitioning choices for parallel regions)

2021-04-26 Thread Tobias Burnus
On 26.04.21 14:32, Tobias Burnus wrote: Secondly, I now see FAILs like: FAIL: gfortran.dg/goacc/classify-serial.f95 -O (test for excess errors) [...] Now fixed myself to reduce the clutter. Committed as r12-130-g5a26ba75de623f75fb44cddc2a9c982d31c96213 Tobias - Mentor Gra

Re: [PATCH] openacc: Warnings for strange partitioning choices for parallel regions

2021-04-26 Thread Thomas Schwinge
Hi! On 2021-04-26T14:32:10+0200, Tobias Burnus wrote: > first, can you add an entry regarding this flag > to https://gcc.gnu.org/gcc-12/changes.html ? Is that a standard thing that all new command-line flags do get highlighted there? (I wouldn't have considered that one important enough?) > S

Re: [PATCH] openacc: Warnings for strange partitioning choices for parallel regions

2021-04-26 Thread Tobias Burnus
Hi Thomas, first, can you add an entry regarding this flag to https://gcc.gnu.org/gcc-12/changes.html ? Secondly, I now see FAILs like: FAIL: gfortran.dg/goacc/classify-serial.f95 -O (test for excess errors) Excess errors: gfortran.dg/goacc/classify-serial.f95:20:132: Warning: region contain

Re: [PATCH] openacc: Warnings for strange partitioning choices for parallel regions

2021-04-26 Thread Thomas Schwinge
Hi! On 2021-02-26T04:21:54-0800, Julian Brown wrote: > This patch adds warnings for strange partitioning choices -- specifying > either more or fewer partitioning levels on a parallel directive than the > enclosed offload region actually uses. Thanks! > We've used a version of this patch on the

[PATCH] openacc: Warnings for strange partitioning choices for parallel regions

2021-02-26 Thread Julian Brown
This patch adds warnings for strange partitioning choices -- specifying either more or fewer partitioning levels on a parallel directive than the enclosed offload region actually uses. We've used a version of this patch on the og8/og9/og10 branches for quite a while. Versions have been posted for