Re: [PATCH] more warning code refactoring

2021-08-20 Thread Martin Sebor via Gcc-patches
On 8/19/21 7:38 PM, Kewen.Lin wrote: Hi Martin, on 2021/8/20 上午12:30, Martin Sebor wrote: On 8/19/21 9:03 AM, Martin Sebor wrote: On 8/18/21 11:56 PM, Kewen.Lin wrote: Hi David, on 2021/8/19 上午11:26, David Edelsohn via Gcc-patches wrote: Hi, Martin A few PowerPC-specific testcases started

Re: [PATCH] more warning code refactoring

2021-08-19 Thread Kewen.Lin via Gcc-patches
Hi Martin, on 2021/8/20 上午12:30, Martin Sebor wrote: > On 8/19/21 9:03 AM, Martin Sebor wrote: >> On 8/18/21 11:56 PM, Kewen.Lin wrote: >>> Hi David, >>> >>> on 2021/8/19 上午11:26, David Edelsohn via Gcc-patches wrote: Hi, Martin A few PowerPC-specific testcases started failing yeste

Re: [PATCH] more warning code refactoring

2021-08-19 Thread Segher Boessenkool
On Thu, Aug 19, 2021 at 12:53:16PM -0600, Martin Sebor wrote: > That said, I introduced > the variable in r243470 to begin with and I consider its removal > a trivially correct and appropriate part of refactoring. It is not a refactoring. It changes behaviour. Segher

Re: [PATCH] more warning code refactoring

2021-08-19 Thread Martin Sebor via Gcc-patches
On 8/19/21 9:36 AM, Segher Boessenkool wrote: On Thu, Aug 19, 2021 at 09:03:44AM -0600, Martin Sebor via Gcc-patches wrote: On 8/18/21 11:56 PM, Kewen.Lin wrote: To get rid of GTY variable alloc_object_size_limit looks suspicious, maybe tree objects returned by alloc_max_size after the change a

Re: [PATCH] more warning code refactoring

2021-08-19 Thread Martin Sebor via Gcc-patches
On 8/19/21 9:03 AM, Martin Sebor wrote: On 8/18/21 11:56 PM, Kewen.Lin wrote: Hi David, on 2021/8/19 上午11:26, David Edelsohn via Gcc-patches wrote: Hi, Martin A few PowerPC-specific testcases started failing yesterday on AIX with a strange failure mode: the compiler runs out of memory.  As yo

Re: [PATCH] more warning code refactoring

2021-08-19 Thread David Edelsohn via Gcc-patches
Hi, Kewen Good catch! The patch is in the right direction, but gimple-ssa-warn-access.cc is the first file that requires GTY and ends in ".cc". The GCC Makefile machinery to create the GTY headers performs the substitution for files with file extension ".c", so this requires more adjustment in t

Re: [PATCH] more warning code refactoring

2021-08-19 Thread Segher Boessenkool
On Thu, Aug 19, 2021 at 09:03:44AM -0600, Martin Sebor via Gcc-patches wrote: > On 8/18/21 11:56 PM, Kewen.Lin wrote: > >To get rid of GTY variable alloc_object_size_limit looks suspicious, > >maybe tree objects returned by alloc_max_size after the change are out > >of GC's tracking? > > I wouldn'

Re: [PATCH] more warning code refactoring

2021-08-19 Thread Martin Sebor via Gcc-patches
On 8/18/21 11:56 PM, Kewen.Lin wrote: Hi David, on 2021/8/19 上午11:26, David Edelsohn via Gcc-patches wrote: Hi, Martin A few PowerPC-specific testcases started failing yesterday on AIX with a strange failure mode: the compiler runs out of memory. As you may expect from telling you this in an

Re: [PATCH] more warning code refactoring

2021-08-19 Thread Segher Boessenkool
Hi! On Thu, Aug 19, 2021 at 01:56:56PM +0800, Kewen.Lin via Gcc-patches wrote: > on 2021/8/19 上午11:26, David Edelsohn via Gcc-patches wrote: > > A few PowerPC-specific testcases started failing yesterday on AIX with > > a strange failure mode: the compiler runs out of memory. As you may > > expec

Re: [PATCH] more warning code refactoring

2021-08-18 Thread Kewen.Lin via Gcc-patches
Hi David, on 2021/8/19 上午11:26, David Edelsohn via Gcc-patches wrote: > Hi, Martin > > A few PowerPC-specific testcases started failing yesterday on AIX with > a strange failure mode: the compiler runs out of memory. As you may > expect from telling you this in an email reply to your patch, I ha

Re: [PATCH] more warning code refactoring

2021-08-18 Thread David Edelsohn via Gcc-patches
Hi, Martin A few PowerPC-specific testcases started failing yesterday on AIX with a strange failure mode: the compiler runs out of memory. As you may expect from telling you this in an email reply to your patch, I have bisected the failure and landed on your commit. I can alternate between the p

Re: [PATCH] more warning code refactoring

2021-08-17 Thread Martin Sebor via Gcc-patches
On 8/17/21 2:51 AM, Richard Biener wrote: On Tue, Aug 17, 2021 at 3:52 AM Martin Sebor via Gcc-patches wrote: The attached patch continues with the move of warning code from builtins.c and calls.c into a more suitable home. As before, it is mostly free of functional changes. The one exceptio

Re: [PATCH] more warning code refactoring

2021-08-17 Thread Richard Biener via Gcc-patches
On Tue, Aug 17, 2021 at 3:52 AM Martin Sebor via Gcc-patches wrote: > > The attached patch continues with the move of warning code from > builtins.c and calls.c into a more suitable home. As before, it > is mostly free of functional changes. The one exception is that > as pleasant a side-effect,

[PATCH] more warning code refactoring

2021-08-16 Thread Martin Sebor via Gcc-patches
The attached patch continues with the move of warning code from builtins.c and calls.c into a more suitable home. As before, it is mostly free of functional changes. The one exception is that as pleasant a side-effect, moving the attribute access checking from initialize_argument_information() i