Re: [C++ Patch PING] Re: [PATCH] make excessive template instantiation depth a fatal error

2014-09-30 Thread Paolo Carlini
Hi, On 09/30/2014 04:51 PM, Manuel López-Ibáñez wrote: I don't want to cause you more work Paolo, but perhaps this should be documented in https://gcc.gnu.org/gcc-5/changes.html. ? Something like: * Excessive template instantiation depth is now a fatal error. This prevents excessive diagnostic

Re: [C++ Patch PING] Re: [PATCH] make excessive template instantiation depth a fatal error

2014-09-30 Thread Manuel López-Ibáñez
I don't want to cause you more work Paolo, but perhaps this should be documented in https://gcc.gnu.org/gcc-5/changes.html. ? Something like: * Excessive template instantiation depth is now a fatal error. This prevents excessive diagnostics that usually do not help to identify the problem. Thank

Re: [C++ Patch PING] Re: [PATCH] make excessive template instantiation depth a fatal error

2014-09-30 Thread Jason Merrill
OK. Jason

Re: [C++ Patch PING] Re: [PATCH] make excessive template instantiation depth a fatal error

2014-09-30 Thread Paolo Carlini
... forgot to attach the complete patch ;) Paolo. Index: cp/cp-tree.h === --- cp/cp-tree.h(revision 215710) +++ cp/cp-tree.h(working copy) @@ -5418,7 +5418,6 @@ extern const char *lang_decl_n

[C++ Patch PING] Re: [PATCH] make excessive template instantiation depth a fatal error

2014-09-30 Thread Paolo Carlini
Hi all, hi Jason, On 08/24/2014 12:11 PM, Manuel López-Ibáñez wrote: PING: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg01709.html Today, I picked this unreviewed patch prepared by Manuel back in August and trivially completed it by adjusting the testcases (all the tweaks seem the expected on

Re: [PATCH] make excessive template instantiation depth a fatal error

2014-08-24 Thread Manuel López-Ibáñez
PING: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg01709.html On 18 August 2014 00:03, Manuel López-Ibáñez wrote: > Following a suggestion in PR16564, this patch makes excessive template > instantiation depth a fatal error. In fact, this allows simplifying > the code a lot, just by printing firs

[PATCH] make excessive template instantiation depth a fatal error

2014-08-17 Thread Manuel López-Ibáñez
Following a suggestion in PR16564, this patch makes excessive template instantiation depth a fatal error. In fact, this allows simplifying the code a lot, just by printing first the context (like we do for every other diagnostic) instead of printing it after (which is not possible for a fatal error