Re: [PATCH] m68k: Quiet up cppcheck warning [PR114689]

2024-04-15 Thread Jeff Law
On 4/15/24 8:43 AM, Jakub Jelinek wrote: Hi! cppcheck apparently warns on the | !!sticky part of the expression and using | (!!sticky) quiets it up (it is correct as is). The following patch adds the ()s, and also adds them around mant >> 1 just in case it makes it clearer to all readers that

[PATCH] m68k: Quiet up cppcheck warning [PR114689]

2024-04-15 Thread Jakub Jelinek
Hi! cppcheck apparently warns on the | !!sticky part of the expression and using | (!!sticky) quiets it up (it is correct as is). The following patch adds the ()s, and also adds them around mant >> 1 just in case it makes it clearer to all readers that the expression is parsed that way already. O