Thank you so much for taking the benchmark! This is a great improvement
than I thought.
In GCC contributions, do I need to benchmark (and report) every built-in
trait I implement?
On Mon, Mar 20, 2023 at 8:24 AM Patrick Palka wrote:
> On Mon, Mar 20, 2023 at 5:56 AM Ken Matsui
> wrote:
> >
> >
On Mon, Mar 20, 2023 at 5:56 AM Ken Matsui wrote:
>
> > Does it actually make compilation faster though?
> >
> > Has it been measured?
>
> In my understanding, what I have implemented so far is so simple that
> it does not affect the speed. These traits are what Partick kindly
> recommended to get
It looks like I was able to use git send-email. The new patches became
a series, so I couldn't figure out how to associate them with this
email and another email. Please disregard this email.
On Mon, Mar 20, 2023 at 2:56 AM Ken Matsui wrote:
>
> > Does it actually make compilation faster though?
> Does it actually make compilation faster though?
>
> Has it been measured?
In my understanding, what I have implemented so far is so simple that
it does not affect the speed. These traits are what Partick kindly
recommended to get started. As explained on the GSoC page, some traits
might involve
On Mon, 20 Mar 2023 at 08:08, Xi Ruoyao via Libstdc++
wrote:
>
> On Mon, 2023-03-20 at 01:03 -0700, Ken Matsui wrote:
> > Oops, I assumed those were my email... Thank you for your heads up and
> > your comments!
> >
> > > Bad ChangeLog format. You should have a tab (not 4 or 8 spaces, nor
> > > n
Thank you!
On Mon, Mar 20, 2023 at 1:07 AM Xi Ruoyao wrote:
>
> On Mon, 2023-03-20 at 01:03 -0700, Ken Matsui wrote:
> > Oops, I assumed those were my email... Thank you for your heads up and
> > your comments!
> >
> > > Bad ChangeLog format. You should have a tab (not 4 or 8 spaces, nor
> > > n
On Mon, 2023-03-20 at 01:03 -0700, Ken Matsui wrote:
> Oops, I assumed those were my email... Thank you for your heads up and
> your comments!
>
> > Bad ChangeLog format. You should have a tab (not 4 or 8 spaces, nor
> > nothing) to indent the ChangeLog content.
>
> Do you mean like the followin
Oops, I assumed those were my email... Thank you for your heads up and
your comments!
> Bad ChangeLog format. You should have a tab (not 4 or 8 spaces, nor
> nothing) to indent the ChangeLog content.
Do you mean like the following?
```
libstdc++-v3/ChangeLog:
[TAB]* include/std/type_traits (is
On Mon, 2023-03-20 at 00:30 -0700, Ken Matsui wrote:
> I see. Thank you!
Please continue to read. I guess you missed some inline comments from
me...
>
> On Mon, Mar 20, 2023 at 12:26 AM Xi Ruoyao wrote:
> >
> > You need to CC libstd...@gcc.gnu.org for any patches touching
> > libstdc++.
> >
I see. Thank you!
On Mon, Mar 20, 2023 at 12:26 AM Xi Ruoyao wrote:
>
> You need to CC libstd...@gcc.gnu.org for any patches touching libstdc++.
>
> On Sat, 2023-03-18 at 21:21 -0700, Ken Matsui via Gcc-patches wrote:
> > libstdc++-v3/ChangeLog:
> >
> > * include/std/type_traits (is_reference): U
You need to CC libstd...@gcc.gnu.org for any patches touching libstdc++.
On Sat, 2023-03-18 at 21:21 -0700, Ken Matsui via Gcc-patches wrote:
> libstdc++-v3/ChangeLog:
>
> * include/std/type_traits (is_reference): Use __is_reference built-in
> trait.
Bad ChangeLog format. You should have a tab
libstdc++-v3/ChangeLog:
* include/std/type_traits (is_reference): Use __is_reference built-in trait.
---
diff --git a/libstdc++-v3/include/std/type_traits
b/libstdc++-v3/include/std/type_traits
index 2bd607a8b8f..18408d8ceb6 100644
--- a/libstdc++-v3/include/std/type_traits
+++ b/libstdc++-v3/incl
12 matches
Mail list logo
