Re: [PATCH] libstdc++: unused local declarations

2024-08-28 Thread Jonathan Wakely
On Wed, 28 Aug 2024 at 10:45, Jonathan Wakely wrote: > > On Wed, 28 Aug 2024 at 10:38, Jason Merrill wrote: > > > > Tested x86_64-pc-linux-gnu. OK for trunk, or were these supposed to be > > used? > > I think the _RefT typedef was used in an earlier version of the code > (possibly a much earlie

Re: [PATCH] libstdc++: unused local declarations

2024-08-28 Thread Jonathan Wakely
On Wed, 28 Aug 2024 at 10:38, Jason Merrill wrote: > > Tested x86_64-pc-linux-gnu. OK for trunk, or were these supposed to be used? I think the _RefT typedef was used in an earlier version of the code (possibly a much earlier version that was never even pushed). It can be removed. I think the _

[PATCH] libstdc++: unused local declarations

2024-08-28 Thread Jason Merrill
Tested x86_64-pc-linux-gnu. OK for trunk, or were these supposed to be used? -- 8< -- The __ok variable and _RefT typedef aren't used in the rest of their blocks. Should they be? libstdc++-v3/ChangeLog: * include/std/format (check_dynamic_spec): Add [[maybe_unused]]. * include/