Re: [PATCH] libstdc++: testsuite: avoid predictable mkstemp

2022-07-05 Thread Jonathan Wakely via Gcc-patches
On Tue, 5 Jul 2022 at 18:46, Alexandre Oliva wrote: > > On Jul 5, 2022, Jonathan Wakely wrote: > > > The cast itself is fine, but I'd like a comment like "N.B. pid_t is a > > pointer on vxworks" so I don't "simplify" it again. > > > libstdc++: testsuite: why cast getpid result > > Add a comment

Re: [PATCH] libstdc++: testsuite: avoid predictable mkstemp

2022-07-05 Thread Alexandre Oliva via Gcc-patches
On Jul 5, 2022, Jonathan Wakely wrote: > The cast itself is fine, but I'd like a comment like "N.B. pid_t is a > pointer on vxworks" so I don't "simplify" it again. libstdc++: testsuite: why cast getpid result Add a comment next to the getpid call to explain why the typecast is needed. Regst

Re: [PATCH] libstdc++: testsuite: avoid predictable mkstemp

2022-07-05 Thread Jonathan Wakely via Gcc-patches
On Tue, 5 Jul 2022 at 10:10, Alexandre Oliva via Libstdc++ wrote: > > On Jun 27, 2022, Alexandre Oliva wrote: > > > On Jun 23, 2022, Jonathan Wakely wrote: > >> The attached makes this a bit more efficient, and makes more of the > >> code common to the mkstemp and non-mkstmp branches. I'll wait

Re: [PATCH] libstdc++: testsuite: avoid predictable mkstemp

2022-07-05 Thread Alexandre Oliva via Gcc-patches
On Jun 27, 2022, Alexandre Oliva wrote: > On Jun 23, 2022, Jonathan Wakely wrote: >> The attached makes this a bit more efficient, and makes more of the >> code common to the mkstemp and non-mkstmp branches. I'll wait to hear >> back from you before pushing it (since it has Joel's name on the >>

Re: [PATCH] libstdc++: testsuite: avoid predictable mkstemp

2022-06-27 Thread Jonathan Wakely via Gcc-patches
On Mon, 27 Jun 2022 at 10:32, Alexandre Oliva wrote: > > On Jun 23, 2022, Jonathan Wakely wrote: > > > The attached makes this a bit more efficient, and makes more of the > > code common to the mkstemp and non-mkstmp branches. I'll wait to hear > > back from you before pushing it (since it has Jo

Re: [PATCH] libstdc++: testsuite: avoid predictable mkstemp

2022-06-27 Thread Alexandre Oliva via Gcc-patches
On Jun 23, 2022, Jonathan Wakely wrote: > The attached makes this a bit more efficient, and makes more of the > code common to the mkstemp and non-mkstmp branches. I'll wait to hear > back from you before pushing it (since it has Joel's name on the > patch). Thanks, I've given it a spin, both tr

Re: [PATCH] libstdc++: testsuite: avoid predictable mkstemp

2022-06-23 Thread Jonathan Wakely via Gcc-patches
On Thu, 23 Jun 2022 at 12:39, Alexandre Oliva wrote: > > On Jun 22, 2022, Jonathan Wakely wrote: > > > On Wed, 22 Jun 2022 at 07:05, Alexandre Oliva via Libstdc++ > > wrote: > > >> It was prompted by a target system with a non-random implementation of > >> mkstemp, that returns a predictable seq

Re: [PATCH] libstdc++: testsuite: avoid predictable mkstemp

2022-06-23 Thread Alexandre Oliva via Gcc-patches
On Jun 22, 2022, Jonathan Wakely wrote: > On Wed, 22 Jun 2022 at 07:05, Alexandre Oliva via Libstdc++ > wrote: >> It was prompted by a target system with a non-random implementation of >> mkstemp, that returns a predictable sequence of filenames and selects >> the first one that isn't already t

Re: [PATCH] libstdc++: testsuite: avoid predictable mkstemp

2022-06-22 Thread Jonathan Wakely via Gcc-patches
On Wed, 22 Jun 2022 at 07:05, Alexandre Oliva via Libstdc++ wrote: > > > This patch was originally meant to reduce the likelihood that > nonexistent_path() returns the same pathname for from and to. > > It was prompted by a target system with a non-random implementation of > mkstemp, that returns

[PATCH] libstdc++: testsuite: avoid predictable mkstemp

2022-06-21 Thread Alexandre Oliva via Gcc-patches
This patch was originally meant to reduce the likelihood that nonexistent_path() returns the same pathname for from and to. It was prompted by a target system with a non-random implementation of mkstemp, that returns a predictable sequence of filenames and selects the first one that isn't alread