Re: [PATCH] libstdc++: istreambuf_iterator proxy (was: keep attached streambuf)

2017-10-10 Thread Jonathan Wakely
On 06/10/17 18:01 +0200, François Dumont wrote: On 03/10/2017 22:39, Petr Ovtchenkov wrote: On Thu, 28 Sep 2017 13:38:06 +0100 Jonathan Wakely wrote: On 28/09/17 15:06 +0300, Petr Ovtchenkov wrote: On Thu, 28 Sep 2017 11:34:25 +0100 Jonathan Wakely wrote: + VERIFY(i == std::istreambuf_ite

Re: [PATCH] libstdc++: istreambuf_iterator proxy

2017-10-09 Thread Petr Ovtchenkov
On Sun, 8 Oct 2017 16:59:39 +0200 François Dumont wrote: > ... > >>> We have three issues with istreambuf_iterator: > >>> - debug-dependent behaviour > >> Fixed. > > + __glibcxx_requires_cond(_M_sbuf, > > _M_message(__gnu_debug::__msg_inc_istreambuf) > >

Re: [PATCH] libstdc++: istreambuf_iterator proxy

2017-10-09 Thread Petr Ovtchenkov
On Sun, 8 Oct 2017 16:59:39 +0200 François Dumont wrote: > ... > >> > >> Consider this code: > >> > >>   std::istringstream inf("abc"); > >>   std::istreambuf_iterator j(inf), eof; > >>   std::istreambuf_iterator i = j++; > >> > >>   assert( *i == 'a' ); > >> > >> At this point it looks l

Re: [PATCH] libstdc++: istreambuf_iterator proxy

2017-10-08 Thread François Dumont
On 06/10/2017 20:00, Petr Ovtchenkov wrote: On Fri, 6 Oct 2017 18:01:36 +0200 François Dumont wrote: ... The test itself simulate "stop and go" istream usage. stringstream is convenient for behaviuor illustration, but in "real life" I can assume socket or tty on this place. At the very minim

Re: [PATCH] libstdc++: istreambuf_iterator proxy (was: keep attached streambuf)

2017-10-06 Thread Petr Ovtchenkov
On Fri, 6 Oct 2017 18:01:36 +0200 François Dumont wrote: > ... > >>> The test itself simulate "stop and go" istream usage. > >>> stringstream is convenient for behaviuor illustration, but in "real life" > >>> I can assume socket or tty on this place. > >> At the very minimum we should have a comm

Re: [PATCH] libstdc++: istreambuf_iterator proxy (was: keep attached streambuf)

2017-10-06 Thread François Dumont
On 03/10/2017 22:39, Petr Ovtchenkov wrote: On Thu, 28 Sep 2017 13:38:06 +0100 Jonathan Wakely wrote: On 28/09/17 15:06 +0300, Petr Ovtchenkov wrote: On Thu, 28 Sep 2017 11:34:25 +0100 Jonathan Wakely wrote: + VERIFY(i == std::istreambuf_iterator()); + + VERIFY(memcmp(b, r, 36) == 0); + +