Re: [PATCH] libstdc++: Stop defining _GLIBCXX_ASSERTIONS in floating_to_chars.cc

2022-04-19 Thread Jonathan Wakely via Gcc-patches
On Thu, 14 Apr 2022 at 20:48, Patrick Palka via Libstdc++ wrote: > > Assertions were originally enabled in the compiled-in floating-point > std::to_chars implementation to help shake out any bugs, but they > apparently impose a significant performance penalty, in particular for > the hex formattin

[PATCH] libstdc++: Stop defining _GLIBCXX_ASSERTIONS in floating_to_chars.cc

2022-04-14 Thread Patrick Palka via Gcc-patches
Assertions were originally enabled in the compiled-in floating-point std::to_chars implementation to help shake out any bugs, but they apparently impose a significant performance penalty, in particular for the hex formatting which is around 25% slower with assertions enabled. This seems too high of