Re: [PATCH] libstdc++: Rename __null_terminated to avoid collision with Apple SDK

2022-06-13 Thread Jonathan Wakely via Gcc-patches
On Fri, 10 Jun 2022 at 22:42, Mark Mentovai wrote: > > Thanks, Jonathan. I am, in fact, so certifying. Great, thanks. > > I do believe that bringing up support for new OS versions is in scope for > open branches, and it makes sense to merge, particularly for a trivial and > uncontentious patch

Re: [PATCH] libstdc++: Rename __null_terminated to avoid collision with Apple SDK

2022-06-10 Thread Mark Mentovai
Thanks, Jonathan. I am, in fact, so certifying. I do believe that bringing up support for new OS versions is in scope for open branches, and it makes sense to merge, particularly for a trivial and uncontentious patch like this one. Jonathan Wakely wrote: > On Fri, 10 Jun 2022 at 21:12, Mark Ment

Re: [PATCH] libstdc++: Rename __null_terminated to avoid collision with Apple SDK

2022-06-10 Thread Jonathan Wakely via Gcc-patches
On Fri, 10 Jun 2022 at 21:12, Mark Mentovai wrote: > > The macOS 13 SDK (and equivalent-version iOS and other Apple OS SDKs) > contain this definition in : > > 863 #define __null_terminated > > This collides with the use of __null_terminated in libstdc++'s > experimental fs_path.h. > > As libstdc

[PATCH] libstdc++: Rename __null_terminated to avoid collision with Apple SDK

2022-06-10 Thread Mark Mentovai
The macOS 13 SDK (and equivalent-version iOS and other Apple OS SDKs) contain this definition in : 863 #define __null_terminated This collides with the use of __null_terminated in libstdc++'s experimental fs_path.h. As libstdc++'s use of this token is entirely internal to fs_path.h, the simples