Re: [PATCH] libstdc++: Hide TLS variables in `std::call_once`

2025-05-06 Thread Martin Storsjö
On Wed, 2 Apr 2025, Martin Storsjö wrote: On Fri, 29 Nov 2024, LIU Hao wrote: 在 2024-11-29 23:50, Jonathan Wakely 写道: It looks like your patch is against gcc-14 not trunk, the GLIBCXX_15.1.0 version is already there. Sorry, I mean GLIBCXX_3.4.34 for 15.1.0 Oops that's what I used to test

Re: [PATCH] libstdc++: Hide TLS variables in `std::call_once`

2025-04-02 Thread Martin Storsjö
On Fri, 29 Nov 2024, LIU Hao wrote: 在 2024-11-29 23:50, Jonathan Wakely 写道: It looks like your patch is against gcc-14 not trunk, the GLIBCXX_15.1.0 version is already there. Sorry, I mean GLIBCXX_3.4.34 for 15.1.0 Oops that's what I used to test the patch. Reapplied to master now. Ping -

Re: [PATCH] libstdc++: Hide TLS variables in `std::call_once`

2024-11-29 Thread LIU Hao
From bafa1604e632d621a57b50ccd9d7a87b01822fd7 Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Fri, 29 Nov 2024 17:17:01 +0800 Subject: [PATCH] libstdc++: Hide TLS variables in `std::call_once` This is a transitional change for PR80881, because on Windows, thread-local variables can't be exported from a

Re: [PATCH] libstdc++: Hide TLS variables in `std::call_once`

2024-11-29 Thread Jonathan Wakely
On Fri, 29 Nov 2024 at 15:49, Jonathan Wakely wrote: > > On Fri, 29 Nov 2024 at 15:31, LIU Hao wrote: > > > > 在 2024-11-29 23:08, Jonathan Wakely 写道: > > > The change seems reasonable but this needs a change to > > > config/abi/pre/gnu.ver to export the new symbol in the GLIBCXX_3.4.34 > > > vers

Re: [PATCH] libstdc++: Hide TLS variables in `std::call_once`

2024-11-29 Thread Jonathan Wakely
On Fri, 29 Nov 2024 at 15:31, LIU Hao wrote: > > 在 2024-11-29 23:08, Jonathan Wakely 写道: > > The change seems reasonable but this needs a change to > > config/abi/pre/gnu.ver to export the new symbol in the GLIBCXX_3.4.34 > > version. > > I have added it in the attached patch. However it exists on

Re: [PATCH] libstdc++: Hide TLS variables in `std::call_once`

2024-11-29 Thread LIU Hao
s, LIU Hao From d5cf40386b742a6c2327d2eb5b3685165272f63c Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Fri, 29 Nov 2024 17:17:01 +0800 Subject: [PATCH] libstdc++: Hide TLS variables in `std::call_once` This is a transitional change for PR80881, because on Windows, thread-local variables can't be exported from

Re: [PATCH] libstdc++: Hide TLS variables in `std::call_once`

2024-11-29 Thread Jonathan Wakely
The change seems reasonable but this needs a change to config/abi/pre/gnu.ver to export the new symbol in the GLIBCXX_3.4.34 version. Please add full stops (periods) to the ChangeLog entry, to make complete sentences. Is "PR libstdc++/, target/" valid like that? I don't think it is, it sh

[PATCH] libstdc++: Hide TLS variables in `std::call_once`

2024-11-29 Thread LIU Hao
-- Best regards, LIU Hao From 78ae9cacdfea8bab4fcc8a18068ad30401eb588d Mon Sep 17 00:00:00 2001 From: LIU Hao Date: Fri, 29 Nov 2024 17:17:01 +0800 Subject: [PATCH] libstdc++: Hide TLS variables in `std::call_once` This is a transitional change for PR80881, because on Windows, thread-local