Re: [PATCH] libstdc++: Fix ref_view branch of views::as_const [PR119135]

2025-03-13 Thread Jonathan Wakely
On Thu, 13 Mar 2025 at 03:54, Patrick Palka wrote: > > On Wed, 12 Mar 2025, Patrick Palka wrote: > > > On Wed, 12 Mar 2025, Patrick Palka wrote: > > > > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/14 and > > > perhaps 13? OK for trunk and 14 and 13. > > > > > > N.B. the use of

Re: [PATCH] libstdc++: Fix ref_view branch of views::as_const [PR119135]

2025-03-13 Thread Tomasz Kaminski
On Thu, Mar 13, 2025 at 4:55 AM Patrick Palka wrote: > On Wed, 12 Mar 2025, Patrick Palka wrote: > > > On Wed, 12 Mar 2025, Patrick Palka wrote: > > > > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/14 and > > > perhaps 13? > > > > > > N.B. the use of a constrained auto instead of

Re: [PATCH] libstdc++: Fix ref_view branch of views::as_const [PR119135]

2025-03-12 Thread Patrick Palka
On Wed, 12 Mar 2025, Patrick Palka wrote: > On Wed, 12 Mar 2025, Patrick Palka wrote: > > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/14 and > > perhaps 13? > > > > N.B. the use of a constrained auto instead of a separate static_assert > > in the testcase is unfortunate but I op

Re: [PATCH] libstdc++: Fix ref_view branch of views::as_const [PR119135]

2025-03-12 Thread Patrick Palka
On Wed, 12 Mar 2025, Patrick Palka wrote: > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/14 and > perhaps 13? > > N.B. the use of a constrained auto instead of a separate static_assert > in the testcase is unfortunate but I opted for local consistency for > now. > > -- >8 -- > > U

[PATCH] libstdc++: Fix ref_view branch of views::as_const [PR119135]

2025-03-12 Thread Patrick Palka
Tested on x86_64-pc-linux-gnu, does this look OK for trunk/14 and perhaps 13? N.B. the use of a constrained auto instead of a separate static_assert in the testcase is unfortunate but I opted for local consistency for now. -- >8 -- Unlike for span and empty_view, the range_reference_t of ref_vie