Re: [PATCH] libstdc++: Fix python/ not making install directories

2022-11-14 Thread Jonathan Wakely via Gcc-patches
On Mon, 14 Nov 2022 at 15:58, Arsen Arsenović wrote: > > > Jonathan Wakely writes: > >> It's the first thing the recipe does: > >> > >> install-data-local: gdb.py > >> @$(mkdir_p) $(DESTDIR)$(toolexeclibdir) > >> > >> That's why I'm suggesting to do the same thing for the debug dir. > > > > Th

Re: [PATCH] libstdc++: Fix python/ not making install directories

2022-11-14 Thread Arsen Arsenović via Gcc-patches
Jonathan Wakely writes: >> It's the first thing the recipe does: >> >> install-data-local: gdb.py >> @$(mkdir_p) $(DESTDIR)$(toolexeclibdir) >> >> That's why I'm suggesting to do the same thing for the debug dir. > > This presumably means it has the problems that mkinstalldirs is > supposed t

Re: [PATCH] libstdc++: Fix python/ not making install directories

2022-11-14 Thread Jonathan Wakely via Gcc-patches
On Mon, 14 Nov 2022 at 14:13, Jonathan Wakely wrote: > > On Mon, 14 Nov 2022 at 13:20, Arsen Arsenović wrote: > > > > Hi, > > > > Jonathan Wakely writes: > > >> This looks simple, and more consistent with what we already do. Does > > >> it solve your issue? > > > > It does work; though, if I was

Re: [PATCH] libstdc++: Fix python/ not making install directories

2022-11-14 Thread Jonathan Wakely via Gcc-patches
On Mon, 14 Nov 2022 at 13:20, Arsen Arsenović wrote: > > Hi, > > Jonathan Wakely writes: > >> This looks simple, and more consistent with what we already do. Does > >> it solve your issue? > > It does work; though, if I was more daring I'd have said that it's fine > without checking, too, since i

Re: [PATCH] libstdc++: Fix python/ not making install directories

2022-11-14 Thread Arsen Arsenović via Gcc-patches
Hi, Jonathan Wakely writes: >> This looks simple, and more consistent with what we already do. Does >> it solve your issue? It does work; though, if I was more daring I'd have said that it's fine without checking, too, since it does the same operation on the same directory ;) Was the omission o

Re: [PATCH] libstdc++: Fix python/ not making install directories

2022-11-14 Thread Jonathan Wakely via Gcc-patches
On Mon, 14 Nov 2022 at 10:29, Jonathan Wakely wrote: > > On Sun, 13 Nov 2022 at 18:06, Arsen Arsenović via Libstdc++ > wrote: > > > > I'm unsure why this issue only started manifesting now with how old this > > code is, but this should fix it. > > > > libstdc++-v3/ChangeLog: > > > > * pyth

Re: [PATCH] libstdc++: Fix python/ not making install directories

2022-11-14 Thread Jonathan Wakely via Gcc-patches
On Sun, 13 Nov 2022 at 18:06, Arsen Arsenović via Libstdc++ wrote: > > I'm unsure why this issue only started manifesting now with how old this > code is, but this should fix it. > > libstdc++-v3/ChangeLog: > > * python/Makefile.am: Call mkinstalldirs before INSTALL_DATA > when ins

Re: [PATCH] libstdc++: Fix python/ not making install directories

2022-11-14 Thread Jonathan Wakely via Gcc-patches
On Sun, 13 Nov 2022 at 20:30, Bernhard Reutner-Fischer via Libstdc++ wrote: > > On Sun, 13 Nov 2022 19:42:52 + > Jonathan Wakely via Gcc-patches wrote: > > > On Sun, 13 Nov 2022, 18:06 Arsen Arsenović via Libstdc++, < > > libstd...@gcc.gnu.org> wrote: > > > > > I'm unsure why this issue only

Re: [PATCH] libstdc++: Fix python/ not making install directories

2022-11-13 Thread Bernhard Reutner-Fischer via Gcc-patches
On Sun, 13 Nov 2022 19:42:52 + Jonathan Wakely via Gcc-patches wrote: > On Sun, 13 Nov 2022, 18:06 Arsen Arsenović via Libstdc++, < > libstd...@gcc.gnu.org> wrote: > > > I'm unsure why this issue only started manifesting now with how old this > > code is, but this should fix it. > > > >

Re: [PATCH] libstdc++: Fix python/ not making install directories

2022-11-13 Thread Jonathan Wakely via Gcc-patches
On Sun, 13 Nov 2022, 18:06 Arsen Arsenović via Libstdc++, < libstd...@gcc.gnu.org> wrote: > I'm unsure why this issue only started manifesting now with how old this > code is, but this should fix it. > I just pushed a change to how the debug build makefiles are generated, which presumably uncover

[PATCH] libstdc++: Fix python/ not making install directories

2022-11-13 Thread Arsen Arsenović via Gcc-patches
I'm unsure why this issue only started manifesting now with how old this code is, but this should fix it. libstdc++-v3/ChangeLog: * python/Makefile.am: Call mkinstalldirs before INSTALL_DATA when installing gdb scripts. * python/Makefile.in: Regenerate. --- Hi, Someone sp