Re: [PATCH] libstdc++: Ensure that std::from_chars is declared when supported

2022-03-16 Thread Jonathan Wakely via Gcc-patches
On Mon, 14 Mar 2022 at 14:15, Patrick Palka wrote: > I think __floating_from_chars_hex should work fine on 16 bit targets, > so I suppose we could use it in the !USE_LIB_FAST_FLOAT branch as well. Good point, and even for SIZE_WIDTH >= 32, it might be faster to use your __floating_from_chars_hex f

Re: [PATCH] libstdc++: Ensure that std::from_chars is declared when supported

2022-03-16 Thread Jonathan Wakely via Gcc-patches
On Tue, 15 Mar 2022 at 14:12, Patrick Palka wrote: > > On Mon, 14 Mar 2022, Jonathan Wakely wrote: > > > On Mon, 14 Mar 2022 at 14:17, Patrick Palka via Libstdc++ > > wrote: > > > > > > On Fri, 11 Mar 2022, Jonathan Wakely wrote: > > > > > > > Patrick, I think this is right, but please take a look

Re: [PATCH] libstdc++: Ensure that std::from_chars is declared when supported

2022-03-15 Thread Patrick Palka via Gcc-patches
On Mon, 14 Mar 2022, Jonathan Wakely wrote: > On Mon, 14 Mar 2022 at 14:17, Patrick Palka via Libstdc++ > wrote: > > > > On Fri, 11 Mar 2022, Jonathan Wakely wrote: > > > > > Patrick, I think this is right, but please take a look to double check. > > > > > > I think we should fix the feature-test

Re: [PATCH] libstdc++: Ensure that std::from_chars is declared when supported

2022-03-14 Thread Jonathan Wakely via Gcc-patches
On Mon, 14 Mar 2022 at 14:17, Patrick Palka via Libstdc++ wrote: > > On Fri, 11 Mar 2022, Jonathan Wakely wrote: > > > Patrick, I think this is right, but please take a look to double check. > > > > I think we should fix the feature-test macro conditions for gcc-11 too, > > although it's a bit mor

Re: [PATCH] libstdc++: Ensure that std::from_chars is declared when supported

2022-03-14 Thread Patrick Palka via Gcc-patches
On Fri, 11 Mar 2022, Jonathan Wakely wrote: > Patrick, I think this is right, but please take a look to double check. > > I think we should fix the feature-test macro conditions for gcc-11 too, > although it's a bit more complicated there. It should depend on IEEE > float and double *and* useloca

[PATCH] libstdc++: Ensure that std::from_chars is declared when supported

2022-03-11 Thread Jonathan Wakely via Gcc-patches
Patrick, I think this is right, but please take a look to double check. I think we should fix the feature-test macro conditions for gcc-11 too, although it's a bit more complicated there. It should depend on IEEE float and double *and* uselocale. We don't need the other changes on the branch. --