Re: [PATCH] libstdc++: Compare keys and values separately in flat_map::operator==

2025-05-29 Thread Tomasz Kaminski
On Thu, May 29, 2025 at 4:49 PM Jonathan Wakely wrote: > On Thu, 29 May 2025 at 15:48, Jonathan Wakely wrote: > > > > On Thu, 29 May 2025 at 15:42, Tomasz Kaminski > wrote: > > > > > > > > > > > > On Thu, May 29, 2025 at 3:56 PM Patrick Palka > wrote: > > >> > > >> Tested on x86_64-pc-linux-gn

Re: [PATCH] libstdc++: Compare keys and values separately in flat_map::operator==

2025-05-29 Thread Patrick Palka
On Thu, 29 May 2025, Tomasz Kaminski wrote: > > > On Thu, May 29, 2025 at 4:37 PM Tomasz Kaminski wrote: > > > On Thu, May 29, 2025 at 3:56 PM Patrick Palka wrote: > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/15? > > -- >8 -- > > Instead of effectively doi

Re: [PATCH] libstdc++: Compare keys and values separately in flat_map::operator==

2025-05-29 Thread Jonathan Wakely
On Thu, 29 May 2025 at 15:48, Jonathan Wakely wrote: > > On Thu, 29 May 2025 at 15:42, Tomasz Kaminski wrote: > > > > > > > > On Thu, May 29, 2025 at 3:56 PM Patrick Palka wrote: > >> > >> Tested on x86_64-pc-linux-gnu, does this look OK for trunk/15? > >> > >> -- >8 -- > >> > >> Instead of effe

Re: [PATCH] libstdc++: Compare keys and values separately in flat_map::operator==

2025-05-29 Thread Jonathan Wakely
On Thu, 29 May 2025 at 15:42, Tomasz Kaminski wrote: > > > > On Thu, May 29, 2025 at 3:56 PM Patrick Palka wrote: >> >> Tested on x86_64-pc-linux-gnu, does this look OK for trunk/15? >> >> -- >8 -- >> >> Instead of effectively doing a zipped comparison of the keys and values, >> compare them sepa

Re: [PATCH] libstdc++: Compare keys and values separately in flat_map::operator==

2025-05-29 Thread Tomasz Kaminski
On Thu, May 29, 2025 at 4:37 PM Tomasz Kaminski wrote: > > > On Thu, May 29, 2025 at 3:56 PM Patrick Palka wrote: > >> Tested on x86_64-pc-linux-gnu, does this look OK for trunk/15? >> >> -- >8 -- >> >> Instead of effectively doing a zipped comparison of the keys and values, >> compare them sepa

Re: [PATCH] libstdc++: Compare keys and values separately in flat_map::operator==

2025-05-29 Thread Tomasz Kaminski
On Thu, May 29, 2025 at 3:56 PM Patrick Palka wrote: > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/15? > > -- >8 -- > > Instead of effectively doing a zipped comparison of the keys and values, > compare them separately to leverage the underlying containers' optimized > equality imp

Re: [PATCH] libstdc++: Compare keys and values separately in flat_map::operator==

2025-05-29 Thread Jonathan Wakely
On Thu, 29 May 2025 at 14:55, Patrick Palka wrote: > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk/15? OK for both, thanks. > > -- >8 -- > > Instead of effectively doing a zipped comparison of the keys and values, > compare them separately to leverage the underlying containers' opt

[PATCH] libstdc++: Compare keys and values separately in flat_map::operator==

2025-05-29 Thread Patrick Palka
Tested on x86_64-pc-linux-gnu, does this look OK for trunk/15? -- >8 -- Instead of effectively doing a zipped comparison of the keys and values, compare them separately to leverage the underlying containers' optimized equality implementations. libstdc++-v3/ChangeLog: * include/std/flat_